Make assets PackageCompiler-friendly
#426
Conversation
A possible solution to relocatablilty issues with the hardcoded paths. Embeds the asset folder contents into the precompiled files. When the original folder isn't available (due to relocation) creates a scratchspace containing the original folder contents as uses that instead.
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 74.03% 74.00% -0.04%
==========================================
Files 26 27 +1
Lines 1352 1385 +33
==========================================
+ Hits 1001 1025 +24
- Misses 351 360 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
LGTM, but I do feel like this should go into a separate package. |
|
JuliaPackaging org might be a decent home for it then, do you have access to that one @pfitzseb? (In the meantime I'll push to my personal account.) |
|
I don't. Maybe we can get @staticfloat to handle the transfer if you give him access? |
|
Yeah, I can do that. |
|
Package is at https://github.com/MichaelHatherly/RelocatableFolders.jl and registration PR is JuliaRegistries/General#38805. I'll give @staticfloat access to that repo, and we'll just need to update the registration PR to point to the right place as well. |
|
I accepted the invitation, but I can't see the |
|
Looks like there can only be a single "owner" of a personal repo. I've tried instead to transfer ownership to JuliaPacking but that yielded a "You don’t have the permission to create public repositories on JuliaPackaging" error. |
|
Try transferring it to me, and I'll transfer it to JuliaPackaging |
|
done |
|
Bump. |
As discussed briefly on slack yesterday. A possible solution to relocatablilty issues with the hardcoded paths.
Embeds the asset folder contents into the precompiled files. When the original folder isn't available (due to relocation) creates a scratchspace containing the original folder contents and uses that instead. Might be worth breaking this out into a small package if we actually go with this approach.
The other option is to just go with full artifacts for now until JuliaLang/julia#38696 gives a more lightweight solution. It's a bit of a hassle to update them when things change though, hence why I've given this a try to see how it feels.