Skip to content

Add 404 page #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 27, 2022
Merged

Conversation

CGBassPlayer
Copy link
Collaborator

Fixes #388

  • Add 404 page

I am not sure website nginx container is setup to automatically load the 404. But Hugo has a small note that points to nginx's docs about the error code handling

@gerbrent
Copy link
Collaborator

@CGBassPlayer Looks good so far, any additional changes needed to make this functional as the 404 then? Wondering if this should be draft....? Ready for final review?

@CGBassPlayer
Copy link
Collaborator Author

This should be set from the Hugo side of things. I think the configuration for the nginx should be checked to see if it is setup to automatically redirect to the 404 page when the site has a 404.

@gerbrent
Copy link
Collaborator

^ Anyone willing to tackle this part?

@gerbrent gerbrent added the help wanted Extra attention is needed label Sep 22, 2022
@CGBassPlayer
Copy link
Collaborator Author

CGBassPlayer commented Sep 22, 2022

I'm guessing we need to create an nginx config file to copy into the container? I can try it if everyone else is busy, but it would need someone who actually knows nginx to review it as I am pretty unfamiliar. I also would not be able to get to this until this weekend or beginning next because I am away for a work conference

@CGBassPlayer CGBassPlayer marked this pull request as draft September 25, 2022 20:59
@CGBassPlayer
Copy link
Collaborator Author

Converting back to draft for now. I will into the nginx config stuff in the meantime. If anyone has info on it, please let me know!

Copy link
Collaborator

@elreydetoda elreydetoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else LGTM, after the changes are accepted and the nginx.conf is removed.

My only concern for the solution of us using nginx is if traefik will try and use it's own 404 page instead of allowing nginx to serve the 404 page. I'd imagine it'd default to nginx first (because it's essentially the "application"), but I don't personally know which one it'll use.

@ironicbadger, any thoughts on ⬆️?

CGBassPlayer and others added 3 commits September 27, 2022 11:48
Co-authored-by: elreydetoda <10230166+elreydetoda@users.noreply.github.com>
Co-authored-by: elreydetoda <10230166+elreydetoda@users.noreply.github.com>
@gerbrent gerbrent added in progress currently being worked on and removed help wanted Extra attention is needed labels Sep 27, 2022
@ironicbadger
Copy link
Collaborator

ironicbadger commented Sep 27, 2022

I would imagine that traefik will be transparent in this process.

image

Copy link
Collaborator

@elreydetoda elreydetoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Well based on @ironicbadger 's testing in prod I think this LGTM. @CGBassPlayer mark it ready for review and I'll happily merge it 😁

@CGBassPlayer CGBassPlayer marked this pull request as ready for review September 27, 2022 17:24
@elreydetoda elreydetoda merged commit 2741cc5 into JupiterBroadcasting:main Sep 27, 2022
@CGBassPlayer CGBassPlayer deleted the feature/404-page branch September 27, 2022 17:30
@CGBassPlayer
Copy link
Collaborator Author

Looks like it worked! Thanks everyone for the insight 😄
404 in prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a 404 page
4 participants