Add Mobile Support for Live Status Indicator #487
Conversation
|
I will look at this later today. LOVE the feature though |
There was a problem hiding this comment.
Sorry for the delay, had to get docker working again on my system.
This LGTM, I tested locally during the LUP recording and it seemed to work just fine. Fantastic addition @ChanceM!
|
nice work both of you! |
|
This looks awesome, and I love the pulse effect you added @ChanceM! To allow me to test this (since nothing is live right now 🙃 ) I figured I'd try and get the mocking (we've talked about before) a try 🙃. That way I could see what this actually looks like instead of just understanding how it works with the code 🙂 And I've got a preliminary setup working 😁 Here is just the regular (non-mobile) experience of me loading up and event I'd linked in the smoke test issue, while I'm running the test in Playwright Debug mode (so I can stop it and debug things).
Then this is the addition that @ChanceM made 😁 , current I'm just setting it to mobile view in my dev tools but there's device sizes we can use to modify the viewport during a test to trigger it for our actual testing.
I'll try and make a PR against your PR soon (don't know how much more I'll need to do) @ChanceM, so that we can submit tests along with this new feature 🙂 |
|
Alright, now have mobile testing support working. Just going to build the actual test and then submit the PR 😁
|
|
alright, I submitted a PR against your branch. It checks for the red indicator on a regular and 3 mobile devices (not really mobile devices, but just their viewports), and saves their screenshots. As I mentioned in the PR, it's about 95% working...the only thing not working properly is the screenshot after I expand the menu. Its getting the needed info, but it's also really wide for some reason. Between screenshots I'm testing for the various live indicators. Besides the tests everything else looks good to me, nice job @ChanceM 😁 |
|
This is amazing @elreydetoda !!! Nice idea, and great execution. Gosh you're all so great!! |
|
actually going to merge to develop and then merging my tests on top off that so we can chat about it during Office hours. 😁 |
Adds a small red circle indicator to mobile menu for live status.