Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dpy #1870

Merged
merged 4 commits into from Apr 10, 2019

Conversation

Projects
None yet
4 participants
@jaydenkieran
Copy link
Member

commented Apr 10, 2019

No description provided.

TheerapakG and others added some commits Jan 31, 2019

Fix bandcamp album issue (#1835)
After creating your pull request, tick these boxes if they are applicable to you.

- [x] I have tested my changes against the `review` branch (the latest developmental version), and this pull request is targeting that branch as a base
- [x] I have tested my changes on Python 3.5/3.6

----

### Description
Fix #1827

This is the nicer version of the fix I proposed in the server. Wrapping the lock with try block and catch the exception is not really encourage readability. Here we try to get the actual URL first and then go down the line which is more intuitive.


### Related issues (if applicable)

@jaydenkieran jaydenkieran merged commit 82a3337 into master Apr 10, 2019

1 check was pending

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.