Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audio np counter bug #1892

merged 2 commits into from May 5, 2019


None yet
3 participants
Copy link

commented May 2, 2019

After creating your pull request, tick these boxes if they are applicable to you.

  • I have tested my changes against the review branch (the latest developmental version), and this pull request is targeting that branch as a base
  • I have tested my changes on Python 3.5.3 or higher


Fix #1738, where pausing the music and then resuming it resets the np counter. This fix is a replica of how progress is got in TheerapakG/ModuBot:alpha. However, this is not a proper implementation (based on the TODO) as it relies on the fact that read() reads 20ms worth of audio but there's really nothing we can do if the underlying source does not spit out 20ms worth of audio as it would then be wrong to the documentation anyway.

Related issues (if applicable)

@TheerapakG TheerapakG requested a review from jaydenkieran as a code owner May 2, 2019


This comment has been minimized.

Copy link

commented May 2, 2019

merge this

@jaydenkieran jaydenkieran merged commit 5088cb9 into Just-Some-Bots:review May 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@TheerapakG TheerapakG referenced this pull request May 12, 2019


[review] Fix volume not update until song finishes #1901

2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.