Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to improve readability #64

Open
staaky opened this issue Jul 13, 2019 · 7 comments

Comments

@staaky
Copy link

commented Jul 13, 2019

I think the readability of item combinations can be improved. You can't read combinations quickly right now since you have to look back up to the item you are hovering to understand the combination.

It'll be easier to read when combinations each have one line, so it reads as item + item = item (see attached image).

I put some more ideas in there as well, hope it helps.

Thanks for a great tool!

Suggestions

  • Add icons so each item combination reads as item + item = item on a single line
  • Maybe use = instead of |
  • Add a triangle on top of the popout that points to the item you're hovering
  • Tabs instead of buttons, so you can indicate the active tab
  • Make the entire tab bar draggable (or at least the active tab) and remove the orange bar
  • Add a context menu icon to replace the right click menu
  • Move opacity setting to options to clean up the slider, don't think it's adjusted enough for it to deserve permanent screen space

TFT-Overlay UI Suggestions

@Just2good

This comment has been minimized.

Copy link
Owner

commented Jul 13, 2019

  1. It was like this in previous version but did away with it as it was just clutter.
  2. Planning to keep this design for now (Might change in the future)
  3. Definitely a good idea, but I'm working on something that will help you distinguish which button is toggled/hovered.
  4. They are actually tabs just all styled to be the same, your concept looks really nice and helps distinguish which ones are active. I'll definitely add this.
  5. This one is kinda tough, I've actually been trying to get this to work for the past week and it seems to interfere with the LeftMouse event handler. (Basically won't register clicks because the dragging takes priority)
  6. The context menu icon is another good idea, I'll work on implementing this.
  7. This would solve a ton of issues, so I'll add this.
@staaky

This comment has been minimized.

Copy link
Author

commented Jul 13, 2019

Thanks! You mention that it was just clutter but I disagree. Before using TFT-Overlay I used to open cheat sheets that reads like this, for example: https://www.leagueofgraphs.com/tft/items It's an extra icon, but that makes it easier to read. It's what annoys me about TFT-overlay, so I find myself pulling up the old cheat sheet from time to time.

Maybe this can be optional?

@Just2good

This comment has been minimized.

Copy link
Owner

commented Jul 13, 2019

I'll keep this open and would like your input once I add in the + - changes. Will comment here again when its done to see if you think it is still better to have 1.

@Just2good

This comment has been minimized.

Copy link
Owner

commented Jul 18, 2019

Getting a draggable tab is harder than I thought, going to try something else. Keeping the tab design though. Also context menu is kind of working. Its currently in a test folder but should be pushed to live soon.

@Killerbear

This comment has been minimized.

Copy link

commented Jul 27, 2019

i would also love to see 1. and 2. implemented.
its pretty hard to understand what is happening.
and i still dont get it.
and also what is this (+) and (-) about? You cant add anything. All it is doing is toggle stuff.
i would remove the (+) and (-).
i dont even undestand why you can click on the icons at all.

@Superce1l

This comment has been minimized.

Copy link

commented Aug 7, 2019

The Chinese translation is outdated,need update.

@765643729

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2019

The Chinese translation is outdated,need update.

因为国内的卖外挂的喷子跑过来喷我,说是他汉化的,让我去b站上看,我放弃继续进行国际化文本的提取和中文本地化

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.