Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2500 #2501

Merged
merged 7 commits into from Jan 22, 2022
Merged

Closes #2500 #2501

merged 7 commits into from Jan 22, 2022

Conversation

JustArchi
Copy link
Member

@JustArchi JustArchi commented Jan 22, 2022

Closes #2500

@JustArchi JustArchi added Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. 💣 Breaking changes Issues marked with this label indicate possible breaking changes that might need major version bump. labels Jan 22, 2022
@JustArchi JustArchi marked this pull request as ready for review January 22, 2022 18:18
@JustArchi JustArchi added 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us. and removed 🚧 Work in progress Issues marked with this label are in active work-in-progress and they're not ready for review yet. labels Jan 22, 2022
@JustArchi
Copy link
Member Author

JustArchi commented Jan 22, 2022

Summary of changes in this PR for reviewers:

  • Added IBotCommand2 interface.
  • IBotCommand, Bot.HasAccess() and Commands.Response() (overload which doesn't accept EAccess) is now obsolete.
  • Added Bot.GetAccess(), which returns new EAccess, compared to just rewriting HasAccess() for new overload, I prefer this one, as user may have different use-case than just validating access, for example different logic depending on access of the caller.
  • Added Commands.Response() overload which accepts EAccess from above.
  • Added IBotCommand2 interface which accepts EAccess and is now aware of steamID being 0.
  • IPC commands are now calling Commands.Response() with EAccess of Owner and steamID of 0.
  • Steam commands resolve EAccess of user calling it, then use the overload above with steamID of the caller.
  • Adapted all parts that required adapting in regards to the above.

It's expected that old IBotCommand plugins before this release keep working until obsolete methods are removed in the future release cycle - therefore major bump isn't required just yet.

@JustArchi
Copy link
Member Author

/cc @Abrynos @vital7 @Ryzhehvost

@JustArchi JustArchi removed the 💣 Breaking changes Issues marked with this label indicate possible breaking changes that might need major version bump. label Jan 22, 2022
@JustArchi JustArchi merged commit 4258fed into main Jan 22, 2022
28 checks passed
@JustArchi JustArchi deleted the massive-commands-rewrite-2500 branch January 22, 2022 23:14
@woctezuma
Copy link

woctezuma commented Mar 3, 2022

This change broke Ryzhehvost/BoosterCreator. :'( I need to dive into C# to see what I can do.

Reference:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Issues marked with this label indicate further enhancements to the program, such as new features. 📢 Feedback welcome Issues marked with this label are open to any potential feedback that could help us.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

De-steamify ASF commands
3 participants