Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address isn't understood when e10s is enabled #2

Open
Scrxtchy opened this Issue Nov 11, 2017 · 26 comments

Comments

Projects
None yet
5 participants
@Scrxtchy
Copy link

Scrxtchy commented Nov 11, 2017

Using Latest Waterfox, pressing the extension button brings me to this page

image

@Scrxtchy

This comment has been minimized.

Copy link
Author

Scrxtchy commented Nov 11, 2017

Mitigated locally by navigating to chrome://ca-archive/content/ca-archive.html

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Nov 11, 2017

You probably forced e10s on, unfortunately CAA can't run in this mode for now.

@Scrxtchy Scrxtchy changed the title Address isn't understood Address isn't understood when e10s is enabled Nov 11, 2017

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Nov 11, 2017

I'll try to get it work with e10s, but at the moment it's obviously not my top priority.

@mparnelldmp

This comment has been minimized.

Copy link

mparnelldmp commented Nov 15, 2017

In Waterfox, I have this option, I think because of Tab Mix Plus.

image

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Nov 15, 2017

It seems this is Waterfox-specific feature, patches to run CAA in non-e10 window are welcome.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Dec 5, 2017

As a side note, e10s is enabled by default in Waterfox 56 and not automatically disabled when incompatible extensions are enabled.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Sep 16, 2018

… patches to run CAA in non-e10 window are welcome.

I'd love to contribute but (sorry) no relevant coding skills.

@MrAlex94 please: for the next release of Waterfox (56.2.4, I guess) do we need to seek additional help with this issue?

@JustOff JustOff added the help wanted label Oct 6, 2018

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 7, 2018

(Convoluted workaround for Waterfox non-e10s windows moved to MrAlex94/Waterfox#755 (comment).)

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 7, 2018

That is not a good workaround; please don't share it.
Check CAA 1.2.1b1, which tries to run in a non-e10s window.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 7, 2018

Thanks!

1.2.1b1 is much better. Hopefully no longer any situation in which the modal dialogue will appear.

A couple of edge cases

1

A special URL e.g. about:… as the first and only tab in the only window when Waterfox starts.

2

A preference to Show your windows and tabs from last time when Waterfox starts, with an extension such as Speed Dial caa:addon/speed-dial affecting new tab behaviour, and with the affected tab frontmost in a sole window before quit:

2018-10-07 22 44 23 undefined


In cases such as these there'll be the generic information page:

The address wasn't understood

– with a tab context menu workaround:

2018-10-07 22 45 38 undefined

Alternatively:

  1. close the caa: tab
  2. bring to front any tab with a normal (e.g. http:// or https://) address
  3. reuse the Classic Add-ons Archive button.
@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 8, 2018

The problem here is that Waterfox does not restore the non-e10s status of the windows after restart, so they become unsuitable for caa: scheme. This is pretty sad and now I don’t even know if it's worth using non-e10s windows at all or is't better to return the requirement to disable multi-process mode so as not to confuse anyone with the issue after restarting.

See also CAA 1.2.1b2 = CAA 1.2.1b1 + warning.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 10, 2018

1.2.1b2 feels regressive compared to 1.2.1b1.

I could not remember the two-step workaround that I edited out of the foot of (opening post) MrAlex94/Waterfox#755 (comment).

After I called up an archived copy of that post, 1.2.1b2 felt no different from 1.2.0. (Is there a difference between those two versions?)

… if it's worth using non-e10s windows …

I do think so. 1.2.1b1 felt smart and is likely to satisfy a majority of users.

(The two cases I gave above #2 (comment) are probably very edgy.)

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 10, 2018

Please try CAA 1.2.1b3.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 10, 2018

I seem to get mixed results with 1.2.1b3.

The first impression was good; it was easy to get a window with caa: working.

Later use of the same profile was not easy. I could get only the modal dialogue, with its insistence upon disabling multi-process.

(Maybe the first impression was based on me aiming immediately for the workaround, in response to the generic … not understood … text. Honestly I can't recall exactly what I did immediately at the start of the test.)

Does 1.2.1b3 lack the (1.2.1b1) ability to automatically open a new non-e10s window?

Wording for the non-modal red alert at caa:

Instead of:

Waterfox in multi-process mode can't restore caa: urls after restart!

– maybe this:

Multi-process Waterfox does not save non-e10s state when saving sessions

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 11, 2018

I could get only the modal dialogue, with its insistence upon disabling multi-process.

This modal dialog is called from the block if (mode == e10s && appname != "Waterfox"); do you use any extensions or other ways to hide or fake the application name?

Here is how to check your appname:

  1. Open Scratchpad (Shift+F4)
  2. Set Environment to Browser
  3. Paste alert(Services.appinfo.name); and click Run

Does 1.2.1b3 lack the (1.2.1b1) ability to automatically open a new non-e10s window?

All 1.2.1bX versions have this ability, they differ in the manner in which the e10s mode is detected and in the presence of a non-modal warning.

Wording for the non-modal red alert at caa:

Sorry, but your wording is too general to be useful for the average user.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 11, 2018

… do you use any extensions or other ways to hide or fake the application name?

I'm testing in a profile that has just the one extension.

2018-10-11 20 06 23 javascript application

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 11, 2018

Then I absolutely don't understand how you can see "Multi-process mode is not supported" in 1.2.1b1-b3 🐼

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 12, 2018

@grahamperrin, if you can still reproduce the issue with "Multi-process mode is not supported" is displayed, please email me a copy of the test profile where it's observed (you can reduce the size of the profile by excluding the ca-archive, startupCache and cache2 folders from it).

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 12, 2018

Here it was, the modal, with 1.2.1b3 a few minutes ago (two frames from a screen recording, three seconds apart):

2018-10-12 21 05 frame

2018-10-12 21 08 frame

After removing the extension, quitting, starting, adding the same version: behaviour was quite different – much better, of course :-)

Mysterious.

Unfortunately (sorry) I didn't set aside a copy of the affected profile before working around the mystery but as seen in the second shot above, it was very clean.


PS if it helps to de-mystify: I have a very clear recollection of one of the betas (maybe the first) of 1.2.1 appearing as 1.2.0 at about:addons … I didn't take a shot at the time, I just assumed that you had given a distinctive file name to the .xpi whilst leaving it as 1.2.0 internally. Can't recall which profile was in use when I saw the discrepancy, sorry. I tried, failed, to reproduce the discrepancy.

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 13, 2018

This drives me crazy, 2+2=5 😧

Here is CAA 1.2.1b4, which displays appname instead of "the browser" in the modal dialogue:

if (e10s && Services.appinfo.name != "Waterfox") {
  Services.prompt.alert(null, "Classic Add-ons Archive", 
  "Multi-process mode is not supported now,\nplease disable it and restart " + 
  Services.appinfo.name + ".");
  return;
}
@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 13, 2018

Well … (if we treat the first screenshot in my previous comment as inexplicable) I can not find any situation in which the modal dialogue appears.

Am I missing something?


PS I'm testing primarily with 56.2.3 on FreeBSD-CURRENT, which I expect to be no different from the official 56.2.3 for Linux, for CAA purposes. That's my expectation but for sanity, I'll bring a Kubuntu machine into the mix.

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 13, 2018

This dialogue should never appear in Waterfox, I just don't like to leave inexplicable things unexplained.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 13, 2018

This dialogue should never appear in Waterfox, …

OK 👍

@JustOff

This comment has been minimized.

Copy link
Owner

JustOff commented Oct 14, 2018

I'm going to release 1.2.1 tonight to verify the e10s workaround in the wild.

@grahamperrin

This comment has been minimized.

Copy link

grahamperrin commented Oct 14, 2018

Yep, it feels release-ready to me. Wild time. Thanks.


Back to the opening post, the generic message:

The address wasn’t understood

For #2 (comment) above and the plain English red alert –

Waterfox in multi-process mode can't restore caa: urls after restart!

– I raised the issue in the Waterfox repo:

@BGMcoder

This comment has been minimized.

Copy link

BGMcoder commented Mar 28, 2019

Yes, I have the same problem. CAA gives a "The address wasn’t understood" message in Waterfox 56.2.8 (64-bit). TMP installed and e10's is enabled. It works if I disable e10s. Just confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.