Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escortable NPC's #12

Open
Ravenwolfe opened this issue Feb 6, 2015 · 1 comment
Open

Escortable NPC's #12

Ravenwolfe opened this issue Feb 6, 2015 · 1 comment
Assignees

Comments

@Ravenwolfe
Copy link
Contributor

I found a conflict with Escortable NPC's last night. There seems to be duplicate's.

Scripts/Mobiles/TownFolk has some escortables. Scripts/Quests/Escortables.cs has some too.

There is a EscortableMage : BaseEscortable in the TownFolk folder,
and also an EscortableMage : TownEscortable in the Escortables.cs file. Same class name, different base class.

I noticed this from having an EscortableMage spawned on our shard, where mine are all converted over to use our custom map town names, but this one was still using the Britain town names. It also used the Quest style gump for the discussion. This really about drove me nutz trying to figure out how the heck this NPC could be acting so different than the script I was looking at! lol!

Not sure how to handle this. But one certainly needs changed. The rest are different enough, but still.. both groups of escortables seem to pretty much be doing the same thing, with slight differences. Maybe one group needs removed all together, I dont know.

@Ravenwolfe
Copy link
Contributor Author

Vorspire added:

just wanted to throw this note out there, those things may need a rewrite based on the fact that they are extremely volatile for a stack overflow exception when generating context menu entries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant