Skip to content

/ neverhpfilter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yth_filter requires dimnames attribute #1

Closed
adzemski opened this issue Jan 30, 2020 · 2 comments
Closed

yth_filter requires dimnames attribute #1

adzemski opened this issue Jan 30, 2020 · 2 comments

Comments

@adzemski
Copy link

@adzemski adzemski commented Jan 30, 2020

Generating an xts object from a vector using the xts::xts command does not (unless this is explicitly specified) endow the newly created object with a dimnames attribute.

However running yth_filter on an xts object without a dimnames attribute will generate an error.
@JustinMShea
Copy link
Owner

@JustinMShea JustinMShea commented Feb 3, 2020

Thanks for the heads up!
@JustinMShea
Copy link
Owner

@JustinMShea JustinMShea commented Feb 8, 2020 •
edited

This has been fixed, with branch issue-1, which has been merged to master. Look for release v0.3-0 to be posted soon, which will include updated data as well. See PR #2
@JustinMShea JustinMShea closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JustinMShea @adzemski
You can’t perform that action at this time.