Improve Windows experience #119

Merged
merged 13 commits into from Mar 22, 2013

Projects

None yet

6 participants

@mscdex
mscdex commented Jul 11, 2012

These commits will allow Windows users who do not have zmq installed on their systems to use this module from the get-go with minimal size impact.

@tj
Collaborator
tj commented Jul 11, 2012

gah lol I can't comment on windows stuff, sucks to add more glue. anyone?

@ryangrahamnc

Works for me. I got it installed easily on two Windows 7 computers. It's great because its so smooth now, when normally zeromq.node is a beast to get installed on windows.

@bvarga
bvarga commented Dec 26, 2012

I could use @mscdex fork successfully (thanks), but the best would be if we could install it via npm

@ronkorving
Collaborator

Can we get this to pass travis-ci again? I would love to merge in windows compatibility fixes, but I won't be able to maintain or test myself.

@mscdex
mscdex commented Mar 21, 2013

@ronkorving Fixed.

@ronkorving
Collaborator

@theHazzard and @jcollum from #182 : I assume it works for you with this PR?
@mscdex would you be willing to maintain the windows codebase if we merge this? Also, do you think there is any way to avoid using built-in headers? I would love to hear your thoughts on this.

@ronkorving
Collaborator

@mscdex Is there anything in #125 that needs to be merged into your work?

@mscdex
mscdex commented Mar 21, 2013

@ronkorving I suppose I wouldn't mind keeping it up to date for now. The headers are there because they match the provided pre-compiled libraries.

RE: #125 I'm not sure. What I do know is that my changes allow it to build on Windows successfully and all of the tests pass. Also while on the latter note, it would be great to have the tests run cross-platform (e.g. make a separate node script that runs all of the tests and use that instead of relying on make test).

@theHazzard

@ronkorving it works! at least it compiles! =)

@theHazzard

Works fine on winXP32.

@theHazzard

Works on Win732 too.

@ronkorving
Collaborator

Then I say, let's merge this in and make some Windows users happy. Thanks for all the work on this, @mscdex

@ronkorving ronkorving merged commit 66fd2f6 into JustinTulloss:master Mar 22, 2013

1 check passed

Details default The Travis build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment