Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix semver usage #189

Merged
merged 2 commits into from

2 participants

@AlexeyKupershtokh
Collaborator

1) Don't use semver.satisfies(..., 3.x) fail where constants will likely exist in future libzmq version 4.
2) Added missing argument in semver.gte() that had been leading to test always ignore related constants.

@ronkorving ronkorving merged commit aa5de36 into JustinTulloss:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 test/test.exports.js
View
6 test/test.exports.js
@@ -53,8 +53,8 @@ if (semver.satisfies(zmq.version, '2.x')) {
]);
}
-// 3.x only.
-if (semver.satisfies(zmq.version, '3.x')) {
+// 3.0 and above.
+if (semver.gte(zmq.version, '3.0.0')) {
constants.concat([
'XPUB',
'XSUB',
@@ -64,7 +64,7 @@ if (semver.satisfies(zmq.version, '3.x')) {
}
// 3.2 and above.
-if (semver.gte('3.2')) {
+if (semver.gte(zmq.version, '3.2.0')) {
constants.concat([
'LAST_ENDPOINT'
]);
Something went wrong with that request. Please try again.