Start using node-gyp to build #88

Merged
merged 1 commit into from Mar 15, 2012

Projects

None yet

3 participants

@mojodna
Contributor
mojodna commented Feb 11, 2012

Baby steps. This still needs to move binding.node to the right place and modify NPM's install target, probably among other things.

$ npm install -g node-gyp
$ node-gyp configure --target=0.6
$ node-gyp build

Confirmed working on OS X + Ubuntu 11.10 w/ Node 0.6.10.

(wscript appears to link to uuid, but binding.cc doesn't reference it anywhere.)

@TooTallNate
Contributor

Awesome!

@TooTallNate
Contributor

Note that the files added to the .gitignore file now get generated into the build dir, so the changes to that file aren't necessary. But the binding.gyp file looks good.

/cc @visionmedia

@tj
Collaborator
tj commented Mar 14, 2012

whoop! will this build fine with npm install zmq? @TooTallNate you said npm bundles node-gyp or something now right?

@TooTallNate
Contributor

Ya, if they're on npm 1.1.8 or greater than npm install zmq will use
node-gyp to compile. Note that the "preinstall" or "install" phase
should be removed from the package.json, since npm sniffs for either a
wscript file or a binding.gyp file to do the right thing.

On Wed, Mar 14, 2012 at 2:08 PM, TJ Holowaychuk
reply@reply.github.com
wrote:

whoop! will this build fine with npm install zmq? @TooTallNate  you said npm bundles node-gyp or something now right?


Reply to this email directly or view it on GitHub:
#88 (comment)

@TooTallNate
Contributor

Looks like there's already no "script" phases so that's good. Looks like all you need to do is grab that binding.gyp file!

@tj
Collaborator
tj commented Mar 15, 2012

awesome thanks for the review my friend! merging

@tj tj merged commit 958c2be into JustinTulloss:master Mar 15, 2012
@tj
Collaborator
tj commented Mar 15, 2012

haha i still had npm 1.0.106

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment