add support for checking examples in rst documentations#1
Merged
K-Phoen merged 1 commit intoK-Phoen:masterfrom May 29, 2016
Merged
add support for checking examples in rst documentations#1K-Phoen merged 1 commit intoK-Phoen:masterfrom
K-Phoen merged 1 commit intoK-Phoen:masterfrom
Conversation
| { | ||
| $parser = new Parser(); | ||
|
|
||
| $parser->getEnvironment()->setErrorManager(new class() extends ErrorManager { |
Owner
There was a problem hiding this comment.
Why do we need to do that? Is it going to silence parse errors in the document?
Contributor
Author
There was a problem hiding this comment.
Because some directives are not supported by the parser (we only need the code example directives). And when it appends an ugly echo is made : https://github.com/Gregwar/RST/blob/master/ErrorManager.php#L19. This anonymous class prevents that.
Owner
|
Awesome, thanks for this PR! 👍 |
Owner
|
Merged, thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested on atoum/atoum-documentation#209
Rusty allowed us to find some errors. Thanks.