Make compile with both cgraph and graph library #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraphViz offers two libraries to build up graph structures with: - graph (deprecated) - cgraph Prior to this patch we were only supporting the 'graph' approach. This patch makes it possible to compile both against 'graph' and 'cgraph'. cgraph seems to be available for some time already, but it is not stable for graphviz <2.30.x. For me, gammaray instantly crashes when calling gvContext() in 2.29 (from Ubuntu repositories) when linked against cgraph. Hence we only use cgraph in case we have >=2.30 and when cgraph is actually available. This should also fix the build issues under windows, where the package provided by graphviz.org only provides the cgraph library.
|
Looks good to me, thanks! |
krf
pushed a commit
that referenced
this pull request
Aug 9, 2013
Make compile with both cgraph and graph library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphViz offers two libraries to build up graph structures with:
Prior to this patch we were only supporting the 'graph' approach. This
patch makes it possible to compile both against 'graph' and 'cgraph'.
cgraph seems to be available for some time already, but it is not
stable for graphviz <2.30.x. For me, gammaray instantly crashes when
calling gvContext() in 2.29 (from Ubuntu repositories) when linked
against cgraph. Hence we only use cgraph in case we have >=2.30 and when
cgraph is actually available.
This should also fix the build issues under windows, where the package
provided by graphviz.org only provides the cgraph library.