Remote the displaying of fatal messages. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, thanks! |
This is achieved by forwarding the data to the client and waiting for the data to finish writing. Then the server exits. The client gets the message, displays the dialog. The problem is now that the server disconnected and we currently show another dialog for that (which hides the backtrace) and on accept closes the client.
milianw
added a commit
that referenced
this pull request
Sep 3, 2013
Remote the displaying of fatal messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by forwarding the data to the client and waiting
for the data to finish writing. Then the server exits.
The client gets the message, displays the dialog. The problem
is now that the server disconnected and we currently show another
dialog for that (which hides the backtrace) and on accept closes
the client.