From 6bda5be3e14f6a640602267f775f451ae7aed0d4 Mon Sep 17 00:00:00 2001
From: danieljbruce <danieljbruce@users.noreply.github.com>
Date: Fri, 19 May 2023 15:22:21 -0400
Subject: [PATCH] test: Make the mock server test async (#1283)

* Make the mock server test async

This test uses the done callback which looks confusing. We should. make the test async for readability.

* test: Make the mock server test async

* Remove the unnecessary before block

The service does not need to be initialized in a before block. Move it to where the server is initialized.
---
 test/errors.ts | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/test/errors.ts b/test/errors.ts
index 33721b743..2b72912e4 100644
--- a/test/errors.ts
+++ b/test/errors.ts
@@ -37,23 +37,21 @@ describe('Bigtable/Errors', () => {
   let server: MockServer;
   let bigtable: Bigtable;
   let table: any;
+  let service: MockService;
 
-  before(done => {
-    server = new MockServer(() => {
-      bigtable = new Bigtable({
-        apiEndpoint: `localhost:${server.port}`,
-      });
-      table = bigtable.instance('fake-instance').table('fake-table');
-      done();
+  before(async () => {
+    // make sure we have everything initialized before starting tests
+    const port = await new Promise<string>(resolve => {
+      server = new MockServer(resolve);
+    });
+    bigtable = new Bigtable({
+      apiEndpoint: `localhost:${port}`,
     });
+    service = new BigtableClientMockService(server);
+    table = bigtable.instance('fake-instance').table('fake-table');
   });
 
   describe('with the bigtable data client', () => {
-    let service: MockService;
-    before(async () => {
-      service = new BigtableClientMockService(server);
-    });
-
     describe('sends errors through a streaming request', () => {
       const errorDetails =
         'Table not found: projects/my-project/instances/my-instance/tables/my-table';