Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-working install when installing from AUR packages #127

Closed
Smile4ever opened this issue Feb 21, 2017 · 10 comments
Closed

Non-working install when installing from AUR packages #127

Smile4ever opened this issue Feb 21, 2017 · 10 comments

Comments

@Smile4ever
Copy link

@Smile4ever Smile4ever commented Feb 21, 2017

On Arch Linux, when installing the cerebro and cerebro-git AUR packages result in non-working install. I get the cerebro window, but I can not type in it:
cerebro-arch

If I run cerebro in a terminal, I get no error whatsoever.

AppImage is working fine though.

@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Feb 22, 2017

I confirm, looks like something got changed in the tools that we use to build cerebro. Both packages worked fine when 0.2.6 was released, but now there is a build failure if you clone a repo from scratch. And that is what both AUR packages do, they download sources and build them from scratch.

@KELiON you might want to look into this as well. I have a cloned cerebro repo since a few months, I do a git pull and then try to build - everything is fine. But when I clone the repo from scratch and try to build it, then I get a build failure.

Repro steps:

git clone https://github.com/KELiON/cerebro.git cerebro2
cd cerebro2
npm install
cd app/ 
npm install
cd ../

npm run build

The last command worked earlier and still works on my old-cloned cerebro repository, but it fails on the cerebro2 that I've just cloned above with the following errors:

ERROR in ./app/main/plugins/core/maps/index.js
Module parse failed: /home/maximbaz/private/cerebro2/node_modules/babel-loader/index.js!/home/maximbaz/private/cerebro2/app/main/plugins/core/maps/index.
js Unexpected token (34:63)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (34:63)
    at Parser.pp$4.raise (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:2221:15)
    at Parser.pp.unexpected (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:603:10)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1822:12)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1608:25)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseFunctionBody (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:2098:24)
    at Parser.pp$3.parseArrowExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:2087:10)
    at Parser.pp$3.parseParenArrowList (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1902:17)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1870:21)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
 @ ./app/main/plugins/core/index.js 12:8-25


ERROR in ./app/main/plugins/core/files/getPreview/preview/Archive.js
Module parse failed: /home/maximbaz/private/cerebro2/node_modules/babel-loader/index.js!/home/maximbaz/private/cerebro2/app/main/plugins/core/files/getPr
eview/preview/Archive.js Unexpected token (41:48)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (41:48)
    at Parser.pp$4.raise (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:2221:15)
    at Parser.pp.unexpected (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:603:10)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1822:12)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1608:25)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1608:25)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
    at Parser.pp$3.parseParenAndDistinguishExpression (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1861:32)
    at Parser.pp$3.parseExprAtom (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1796:19)
    at Parser.pp$3.parseExprSubscripts (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1715:21)
    at Parser.pp$3.parseMaybeUnary (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1692:19)
    at Parser.pp$3.parseExprOps (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1637:21)
    at Parser.pp$3.parseMaybeConditional (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1620:21)
    at Parser.pp$3.parseMaybeAssign (/home/maximbaz/private/cerebro2/node_modules/acorn/dist/acorn.js:1597:21)
 @ ./app/main/plugins/core/files/getPreview/index.js 59:15-43
@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Feb 22, 2017

Experiment has shown that the issue is caused by the latest release 6.23.0 of babel. Even though dependency versions are locked, the nested dependency versions are not.

On the working repo:

├─┬ babel-core@6.11.4
│ ├─┬ babel-code-frame@6.22.0
│ │ └── js-tokens@3.0.1
│ ├─┬ babel-generator@6.22.0
│ │ ├─┬ detect-indent@4.0.0
│ │ │ └─┬ repeating@2.0.1
│ │ │   └── is-finite@1.0.2
│ │ └── jsesc@1.3.0
│ ├── babel-helpers@6.22.0
│ ├── babel-messages@6.22.0
│ ├─┬ babel-runtime@6.22.0

On the newly cloned repo:

├─┬ babel-core@6.11.4
│ ├─┬ babel-code-frame@6.22.0
│ │ └── js-tokens@3.0.1
│ ├─┬ babel-generator@6.23.0
│ │ ├─┬ detect-indent@4.0.0
│ │ │ └─┬ repeating@2.0.1
│ │ │   └── is-finite@1.0.2
│ │ ├── jsesc@1.3.0
│ │ └── trim-right@1.0.1
│ ├── babel-helpers@6.23.0
│ ├── babel-messages@6.23.0
│ ├─┬ babel-runtime@6.23.0

@KELiON could you perhaps use npm shrinkwrap to lock the versions of the all the nested dependencies? That way we will not hit any surprises like that in the future. Ideally do it on the repo which doesn't have babel 6.23.0 yet :)

@KELiON
Copy link
Owner

@KELiON KELiON commented Feb 23, 2017

@maximbaz I'll check why it fails on babel 6.23.0 and try to fix it. And I'd just migrate to yarn, that should solve all npm problems.

I thought that fixing versions in package.json is strict enough to avoid this kind of problems, but it is not! Thanks for investigation, @maximbaz

@KELiON
Copy link
Owner

@KELiON KELiON commented Feb 23, 2017

@maximbaz I hope #148 should fix all npm-related shit. Can you try to install Cerebro from scratch from this branch on your machine and let me know if it is ok?

@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Feb 23, 2017

Just tested, works beautifully! Thanks a lot!

For people interested in AUR packages, I can update the build commands for cerebro-git right after #148 is merged into master, but to get the regular cerebro we'd need to wait for the next release.

@jorgicio
Copy link

@jorgicio jorgicio commented Feb 23, 2017

The Yarn update works flawlessly. I maintain the package for Gentoo in my overlay, used yarn instead of npm, and it works fine.

@KELiON
Copy link
Owner

@KELiON KELiON commented Feb 24, 2017

@maximbaz #148 is merged, you can update cerebro-git

@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Feb 24, 2017

Thanks! cerebro-git is working again.

@maximbaz
Copy link
Contributor

@maximbaz maximbaz commented Mar 4, 2017

The cerebro on AUR is updated to 0.2.7, you can get back to stable package if you want 🎉

/cc @Smile4ever, @Godod, @pschmitt, @Cross03, @quatroka, @hughwilliams94, @commanderkelso, @sava-vidakovic, @harryio, @tunnckoCore, @mijoharas, @m1aw.

@tunnckoCore
Copy link

@tunnckoCore tunnckoCore commented Mar 4, 2017

@maximbaz great! 🎉

@KELiON KELiON closed this Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.