Kirill Lashuk KL-7

Organizations

@taste-o-code
KL-7 starred google/bazel
KL-7 opened issue jquery/globalize#407
@KL-7
Expose supplemental CLDR data
KL-7 opened issue jquery/globalize#406
@KL-7
Support for short and long decimal formatting
@KL-7
KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Overall this looks good to me, leaving detailed review for @camertron. Amazing work, @radzinzki!

KL-7 commented on pull request camertron/cldr-plurals-runtime-js#1
@KL-7

Nice catch, @radzinzki! Should we update cldr-plurals-runtime-js version in twitter-cldr-js?

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Something is up with formatting here as well.

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Besides, the class name doesn't match the file name. And do we need RBNF in the class name with it being inside of RBNF module?

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Something went wrong here :) I mean indentation.

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

The build was failing because of a new version of coffee-script-source gem that we indirectly depend on. I froze its version to 1.8.0 in master, we…

KL-7 deleted branch kl_travis_fix at twitter/twitter-cldr-js
@KL-7
@KL-7
@KL-7
  • @KL-7 a6e4ff8
    Freeze coffeescript-source.
@KL-7
@KL-7
  • @KL-7 9b43469
    Update version in JS files.
KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

I just got the same failure after updating History.txt in master :( Looking into it as well.

KL-7 commented on issue twitter/twitter-cldr-js#54
@KL-7

@mathewbgordon I just pushed v2.4.0 to rubygems, give it a try. It contains quite a few resources changes (we upgraded to CLDR v26) and several fix…

@KL-7
KL-7 commented on issue twitter/twitter-cldr-js#54
@KL-7

@mathewbgordon v2.3.2 was released in September, well before the issue was fixed. I guess we should release a new version. Meanwhile, you can try u…

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Module nesting should match directory structure, so this file should either be moved under renderers/test_helpers or the class moved from TestHelpers

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Including my comment above about having a nesting RBNF module defined in numbers/rbnf.rb, I think you could just dump all these small one-line rend…

KL-7 commented on pull request twitter/twitter-cldr-js#60
@KL-7

Same here – use inject so that you don't need to initialize the container separately.