Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change oasis writer defaults to strict + cblocks, discourage the usage of oas.gz #1097

Closed
stefanottili opened this issue Jun 15, 2022 · 2 comments · Fixed by #1148
Closed

Change oasis writer defaults to strict + cblocks, discourage the usage of oas.gz #1097

stefanottili opened this issue Jun 15, 2022 · 2 comments · Fixed by #1148
Assignees
@klayoutmatthias
Labels
enhancement
Milestone
0.27.12

Comments

@stefanottili
Copy link

In order to allow multithreaded oasis reading, would be good for 0.28 to change the default options to write strict oasis with cblocks and to discourage using .gz files.
@klayoutmatthias
Copy link
Collaborator

Changing defaults is easy, but discouraging .gz is difficult - whenever you add ".gz" it's zipped. I don't want to skip that option entirely.

@stefanottili
Copy link
Author

stefanottili commented Jun 15, 2022 via email •
edited
Loading

@klayoutmatthias klayoutmatthias self-assigned this Sep 4, 2022
@klayoutmatthias klayoutmatthias added this to the 0.27.12 milestone Sep 4, 2022
klayoutmatthias added a commit that referenced this issue Sep 4, 2022
@klayoutmatthias
Implemented #1097 (discourage file compression, use CBLOCK)
3dc9a38 
* A warning is printed if file compression is enabled on OASIS
* A hint is present in the writer options
* CBLOCK is default (with fresh config) and for buddy tools
  (use --cblock=false to disable it)
@klayoutmatthias klayoutmatthias linked a pull request Sep 4, 2022 that will close this issue
Issue 1097 #1148
Merged
klayoutmatthias added a commit that referenced this issue Sep 5, 2022
@klayoutmatthias
Issue 1097 (#1148)
390cac8 
* [CONSIDER MERGING] Clarification and typo fixed in DRC doc.

* Implemented #1097 (discourage file compression, use CBLOCK)

* A warning is printed if file compression is enabled on OASIS
* A hint is present in the writer options
* CBLOCK is default (with fresh config) and for buddy tools
  (use --cblock=false to disable it)

* Strict mode is default too.

* Updated tests
klayoutmatthias added a commit that referenced this issue Sep 5, 2022
@klayoutmatthias
Issue 1097 (#1148)
d2ebfff 
* [CONSIDER MERGING] Clarification and typo fixed in DRC doc.

* Implemented #1097 (discourage file compression, use CBLOCK)

* A warning is printed if file compression is enabled on OASIS
* A hint is present in the writer options
* CBLOCK is default (with fresh config) and for buddy tools
  (use --cblock=false to disable it)

* Strict mode is default too.

* Updated tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
enhancement
Projects
None yet
Milestone
0.27.12
Development

Successfully merging a pull request may close this issue.

Issue 1097 KLayout/klayout
2 participants
@klayoutmatthias @stefanottili