Skip to content

Feature request: Include expanded/collapsed state of layer properties into session #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EugeneZelenko opened this issue Jan 13, 2023 · 4 comments
Assignees
Milestone

Comments

@EugeneZelenko
Copy link
Contributor

It'll be great to expanded/collapsed state of layer properties will be stored in/restored from session, especially when layers properties have several levels of nesting.

@EugeneZelenko EugeneZelenko changed the title Include expanded/collapsed state of layer properties into session Feature request: Include expanded/collapsed state of layer properties into session Jan 13, 2023
@EugeneZelenko
Copy link
Contributor Author

Patch.txt

This is my naive implementation of functionality. Python/Ruby API is not supported and most likely is not necessary.

@klayoutmatthias klayoutmatthias self-assigned this Feb 17, 2023
@klayoutmatthias klayoutmatthias added this to the 0.28.6 milestone Feb 17, 2023
@klayoutmatthias
Copy link
Collaborator

This is kind of crazy ...

I picked this topic today and implemented a solution before I noticed your patch. And guess what ... my solution is identical to yours, almost up to single characters. So naive? Surely not ...

However, I added the Ruby/Python interface :)

Nice thing is that expanded/collapsed state now gets persisted in .lyp files as well. A side effect which I think is quite useful. And setting the attribute in Ruby/Python will expand/collapse the tree nodes. So that provides a way to control that feature programmatically.

Matthias

@EugeneZelenko
Copy link
Contributor Author

Hi, Matthias!

Thank you for taking care about this issue! Sure, I could guess some statements, but Ruby/Python interface is complete mystery for me :-) So your solution is definitely better fit into "common picture"!

@klayoutmatthias
Copy link
Collaborator

But your guess was a pretty good one! :)

klayoutmatthias added a commit that referenced this issue Feb 19, 2023
Implemented solution for issue #1249 (persist layer properties in ses…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants