Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding for QObject::findChildren #1357

Closed
EugeneZelenko opened this issue May 2, 2023 · 2 comments
Closed

Add binding for QObject::findChildren #1357

EugeneZelenko opened this issue May 2, 2023 · 2 comments
Assignees
Milestone

Comments

@EugeneZelenko
Copy link
Contributor

Hi, Matthias!

It'll be great to add bindings for QObject::findChildren. See Patch.txt for my naive Qt 5 patch for QList<T> findChildren(const QString &name = QString()) const variant. According to Qt 4 and 6, bindings should be similar, but I had only Qt 5 to verify.

I'm not sure how hard would be findChildren(const QRegularExpression &re) const, but it could be skipped if it's non-trivial.

@klayoutmatthias
Copy link
Collaborator

This code is auto-generated, so patching the file will not survive the next generation run.

The right place was inside scripts/mkqtdecl5/mkqtdecl.conf and correspondingly for Qt4 and Qt6. But the code generation is kind of magic as I run it against a specific golden Qt API.

@EugeneZelenko
Copy link
Contributor Author

EugeneZelenko commented May 3, 2023

Hi, Matthias!

See new patch for script changes. I read Qt 4 and 6 documentation and implementation there should be same.

@klayoutmatthias klayoutmatthias self-assigned this May 12, 2023
@klayoutmatthias klayoutmatthias added this to the 0.28.8 milestone May 12, 2023
klayoutmatthias added a commit that referenced this issue May 13, 2023
Implemented fix for issue #1357 (RBA/pya binding for QObject#findChil…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants