Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for label position in Marker Database Browser #1441

Closed
EugeneZelenko opened this issue Jul 31, 2023 · 6 comments · Fixed by #1443
Closed

Support for label position in Marker Database Browser #1441

EugeneZelenko opened this issue Jul 31, 2023 · 6 comments · Fixed by #1443
Assignees

Comments

@EugeneZelenko
Copy link
Contributor

It'll be great to add support for label position as in GDS format ("n/e/s/w" and their combinations) in Marker Database Browser, so multiple labels could be shown for single violation without using \\n in label text.

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Aug 1, 2023

Ahem ... GDS has "justification" ... but what labels are you talking about? Text objects? These have a justification already. It's called "valign" and "halign" in the DText properties.

@EugeneZelenko
Copy link
Contributor Author

Hi, Matthias!

Sure, halign and valign should be enough. But does rdb reader support them? I looked on _test_extractor_impl for Text/DText and it seems to read only text and transformations, but not alignments.

@klayoutmatthias
Copy link
Collaborator

You're right. That's not supported currently.

Matthias

@klayoutmatthias klayoutmatthias self-assigned this Aug 1, 2023
klayoutmatthias added a commit that referenced this issue Aug 6, 2023
Fixed issue #1441 (RDB support for text attributes like size, font, h…
@EugeneZelenko
Copy link
Contributor Author

Hi, Matthias!

Thank you for such fast implementation!

@nmz787-intel
Copy link

Is this related to text Labels not showing rotation? I see my labels rotated in Calibre, but not KLayout.

@EugeneZelenko
Copy link
Contributor Author

Not, it was about text alignment relative to reference point (above/below/center and left/right/middle). See changes that fixed issues, especially test case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants