Skip to content

strm2oas: def path with first/last segment length < halfwidth are read wrong #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefanottili opened this issue Sep 7, 2023 · 5 comments · Fixed by #1475
Closed

strm2oas: def path with first/last segment length < halfwidth are read wrong #1472

stefanottili opened this issue Sep 7, 2023 · 5 comments · Fixed by #1475
Assignees
Labels
Milestone

Comments

@stefanottili
Copy link

strm2oas by default decomposes multi-point path with first or last segment length < halfwidth incorrectly.
They are read correctly as multi-point path by using the --lefdef-joined-paths option.

make bad; make xor shows the difference
make good; make xor doesn't

test_spnet.tgz

@klayoutmatthias klayoutmatthias self-assigned this Sep 7, 2023
@klayoutmatthias klayoutmatthias added this to the 0.28.12 milestone Sep 7, 2023
@klayoutmatthias
Copy link
Collaborator

Thanks! Perfect testcase preparation!

But hard to fix :(

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Sep 7, 2023

I mean, I don't know if the "good" version is even correct - that assumes a "GDS style" interpretation of path. Can you confirm the way these paths are build is compatible with other tools?

Like this "good" path:

image

while the "bad" version is correct if you imagine a square pen going round the corner left of the small segment:

image

@stefanottili
Copy link
Author

stefanottili commented Sep 7, 2023 via email

@klayoutmatthias
Copy link
Collaborator

Okay ... my fix now is to join the first two segments if the initial segment is too short. Same for the last two segments.

Matthias

@klayoutmatthias klayoutmatthias linked a pull request Sep 9, 2023 that will close this issue
@stefanottili
Copy link
Author

more elaborate then what I would have done, but I'll take it.
I would be nice to get a warning about this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants