Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom fill pattern are read top/bottom flipped from .lyp files #225

Closed
klayoutmatthias opened this issue Jan 16, 2019 · 2 comments
Closed

Custom fill pattern are read top/bottom flipped from .lyp files #225

klayoutmatthias opened this issue Jan 16, 2019 · 2 comments

Comments

@klayoutmatthias
Copy link
Collaborator

@klayoutmatthias klayoutmatthias commented Jan 16, 2019

The effect is this: define a fill pattern in the custom fill pattern area. Pick a pattern which is not symmetric in Y (e.g. a letter "A"). Save the layer properties and load again. Effect: the pattern is flipped and the "A" is bottom-up. Save and load again to revert the effect.

Apparently the .lyp reader flips the pattern.

@klayoutmatthias
Copy link
Collaborator Author

@klayoutmatthias klayoutmatthias commented Jan 16, 2019

Here is a testcase: load 225.gds with 225.lyp...

225.zip

@klayoutmatthias
Copy link
Collaborator Author

@klayoutmatthias klayoutmatthias commented Jan 16, 2019

So the problem can be fixed in two places:

  • In the .lyp reader: this means all existing files from 0.24.x become valid again. But all files tweaked to fit to 0.25.x become flipped.
  • in the .lyp writer: this means all files tweaked for 0.25 stay valid. Old files need to be adapted.

So either solution means, someone will blame me ...

But here is my decision: the first one to complain was using old files he wanted to be correct again. So I'll fix the issue in the READER. Sorry for the others.

klayoutmatthias added a commit that referenced this issue Jan 16, 2019
Fixed #225 by fixing the READER.
klayoutmatthias added a commit that referenced this issue Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant