Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash with custom stipple pattern that contain more than 38 lines #232

Closed
klayoutmatthias opened this Issue Feb 6, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Feb 6, 2019

Klayout reads 38 lines but not more than that …

Test case to be added.

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator Author

klayoutmatthias commented Feb 7, 2019

Here is a testcase:

a.lyp.zip

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator Author

klayoutmatthias commented Feb 23, 2019

The maximum stipple pattern height is 32. When a pattern larger than this is loaded from .lyp, this crash happens. I have limited the reader to 32 and it's safe now. But the pattern is clipped. To allow larger stipple pattern is a bigger effort.
Is this required?

@thomaslima

This comment has been minimized.

Copy link
Collaborator

thomaslima commented Feb 23, 2019

klayoutmatthias added a commit that referenced this issue Feb 23, 2019

Merge pull request #233 from KLayout/issue-232
Fixed #232 by limiting the allowed number of string to the maximum su…

klayoutmatthias added a commit that referenced this issue Feb 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.