Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ruler Property Editor for "LayoutView::create_measure_ruler()" #342

Closed
Kazzz-S opened this issue Sep 1, 2019 · 3 comments

Comments

@Kazzz-S
Copy link
Contributor

commented Sep 1, 2019

This is related to both:

  1. #333
    and
  2. #335

The newly added feature LayoutView::create_measure_ruler() is extremely powerful and useful as I expected! Thank you very much for providing this.

To further enhance this feature, I would like to have an enhanced Ruler Property Editor with a GUI something like below. I hope the GUI is self-explanatory.

RulerPropertiesPage-Automeasure

I'm preparing a separate test report regarding LayoutView::create_measure_ruler() #341 where some issues captured through a kind of stress test will be described.

To me, it seems that the issues are (perhaps) related to the deep part of the "auto measure algorithm."
The implementation of LayoutView::create_measure_ruler() that wraps the algorithm looks fine.

I think this enhanced GUI should help debug the issues, too.

With warm regards,
Kazzz

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

commented Sep 1, 2019

Hi Kazzz,

thanks for this suggestion. I striving for generic functionality with as many use cases as possible. So I'd like to modify the proposal somewhat. Here is an idea:

Screenshot from 2019-09-01 23-19-19

"Swap points" would swap P1 and P2 (a function I wanted myself). "Snap to layout" would snap P1, P2 or both to layout edges.

The seed points would be P1 and P2 then. If you set P1 = P2, the effect is the same as for "create_measure_ruler". All these buttons imply "Apply".

You can try this solution in the "issue-342" branch.

Best regards,

Matthias

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

Hi Matthias,

Thank you again for your positive and prompt action.
Your idea is fine with me. "Swap points" is the one I want, too!

I'll try the branch.

With warm regards,
Kazzz

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Hi Matthias,

I've confirmed that the new GUI in the "issue-342" branch works as you described.
It's fascinating and makes my job easy!

With best regards,
Kazzz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.