Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request (low priority): Bookmarks in "Dock Widget" #343

Closed
Kazzz-S opened this issue Sep 3, 2019 · 7 comments

Comments

@Kazzz-S
Copy link
Contributor

commented Sep 3, 2019

While testing #341 and #342, I needed a bit long bookmark list like:

Sample Bookmark ===> BM-110seeds-RGBY-flags.zip


LongBookMarkList

It would be convenient if the bookmarks are shown in a Doc Widget (or pinned container) not to follow the menu hierarchy again and again.

With warm regards,
Kazzz

klayoutmatthias added a commit that referenced this issue Sep 7, 2019
Implementation of #343 (dockable bookmark window)
Here is the proposal:
- There is a new panel similar to the layer list showing the
  bookmarks. It can be shown using View/Bookmarks.
  Initially this panel is hidden.
- Double-clicking on an item in this bookmark list will
  navigate to the bookmark.
- Context menu entries of this panel are: manage, load and
  save bookmarks (like in main menu)

In addition, "bookmark this view" now proposes a bookmark name
make of "B" and a unique number.
klayoutmatthias added a commit that referenced this issue Sep 8, 2019
Some enhancements to #343 fix
- "follow selection": allows navigating between the bookmarks
  with the cursor keys
- "manage bookmarks" now starts with the selected bookmarks
  also selected.
@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

commented Sep 8, 2019

This is how it looks:

image

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 8, 2019

Awesome!!!

Thank you so much again.

With warm regards,
Kazzz

Kazzz-S added a commit to Kazzz-S/klayout that referenced this issue Sep 8, 2019
Implementation of KLayout#343 (dockable bookmark window)
Here is the proposal:
- There is a new panel similar to the layer list showing the
  bookmarks. It can be shown using View/Bookmarks.
  Initially this panel is hidden.
- Double-clicking on an item in this bookmark list will
  navigate to the bookmark.
- Context menu entries of this panel are: manage, load and
  save bookmarks (like in main menu)

In addition, "bookmark this view" now proposes a bookmark name
make of "B" and a unique number.
Kazzz-S added a commit to Kazzz-S/klayout that referenced this issue Sep 8, 2019
Some enhancements to KLayout#343 fix
- "follow selection": allows navigating between the bookmarks
  with the cursor keys
- "manage bookmarks" now starts with the selected bookmarks
  also selected.
@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

It's released :-)

Ok to close this?

BR, Matthias

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Hi Matthias,

I've built 0.26 on Linux (my primary environment) and found this new feature is handy as expected.
Once again, thank you very much for providing this feature.
Yes, please close this ticket.

I've demonstrated the new version, and my colleagues love this feature, too, and conceived of a new, improved workflow using this feature.

One commented that it would be much better if a bookmark can be selected not only by the mouse click but also by the arrow keys if the focus is in the dock widget.

With warm regards,
Kazzz

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

Hi Matthias,

What it should have been:

One commented that it would be much better if a bookmark can be selected not only by the mouse click but also by the arrow keys if the focus is in the dock widget.

One commented that it would be much better if item selection/change by the arrow keys takes the same effect as the mouse click.

Regards,
Kazzz

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

@Kazzz-S

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

Hi Matthias,

I've confirmed the usage of the context menu.
Selection of bookmark items with the up and down arrow keys helps speedy operation.
Thank you for the proactive user interface design!
Let me close this ticket with this comment.

With best regards,
Kazzz

@Kazzz-S Kazzz-S closed this Sep 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.