Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-path and rdb-file behavior is inconsistent #353

Closed
EugeneZelenko opened this issue Sep 12, 2019 · 4 comments
Closed

file-path and rdb-file behavior is inconsistent #353

EugeneZelenko opened this issue Sep 12, 2019 · 4 comments

Comments

@EugeneZelenko
Copy link

@EugeneZelenko EugeneZelenko commented Sep 12, 2019

When session is loaded with -u layout files as loaded from same directory as session file, but rdb-file is loaded from current working directory. This leads to problem when path in -u and current working directory are different.

Workaround is to use absolute or relative path in rdb-file, but I think will be good idea if KLayout behavior will be consistent in both cases.

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

@klayoutmatthias klayoutmatthias commented Sep 13, 2019

Good point. Makes sense.

Matthias

@EugeneZelenko

This comment has been minimized.

Copy link
Author

@EugeneZelenko EugeneZelenko commented Sep 13, 2019

Sorry, I forgot to mention that I meant that both file-path and rdb-file are just file names without path.

@klayoutmatthias

This comment has been minimized.

Copy link
Collaborator

@klayoutmatthias klayoutmatthias commented Sep 14, 2019

I also noticed that L2N and LVS DB are not included in the sessions. This is inconsistent as RDB's are. I have fixed this as well.

@EugeneZelenko

This comment has been minimized.

Copy link
Author

@EugeneZelenko EugeneZelenko commented Sep 14, 2019

Thank you for quick fix!

klayoutmatthias added a commit that referenced this issue Sep 16, 2019
Fixed #353 (paths relative to .lys file for rdb-file)
klayoutmatthias added a commit that referenced this issue Sep 18, 2019
Consistent behavior for file paths for images too.
Plus: image paths are not kept as absolute paths
inside the session.
This makes regeneration of images stable.
klayoutmatthias added a commit that referenced this issue Sep 29, 2019
Follow-up on #353 (sessions paths relative to session file)
rizoschrist-prime added a commit to rizoschrist-prime/klayout that referenced this issue Oct 8, 2019
Consistent behavior for file paths for images too.
Plus: image paths are not kept as absolute paths
inside the session.
This makes regeneration of images stable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.