Skip to content

/klayout

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strm2oas help prints gds options but does not print oasis options #358

Closed
ghjpk opened this issue Sep 17, 2019 · 1 comment
Closed

strm2oas help prints gds options but does not print oasis options #358

ghjpk opened this issue Sep 17, 2019 · 1 comment

Comments

@ghjpk
Copy link

@ghjpk ghjpk commented Sep 17, 2019

klayout/src/buddies/src/bd/strm2oas.cc sets the format to bd::GenericWriterOptions::gds2_format_name

maybe it needs to be bd::GenericWriterOptions::oasis_format_name ?
@klayoutmatthias

This comment has been minimized.

Sign in to view
Copy link
Collaborator

@klayoutmatthias klayoutmatthias commented Sep 17, 2019

You're perfectly right!

Thanks,

Matthias
klayoutmatthias added a commit that referenced this issue Sep 18, 2019
@klayoutmatthias
Merge pull request #361 from KLayout/issue-358
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9edb9d6 
Fixed #358 (strm2oas was producing GDS)
rizoschrist-prime added a commit to rizoschrist-prime/klayout that referenced this issue Oct 8, 2019
@klayoutmatthias @rizoschrist-prime
Fixed KLayout#358 (strm2oas was producing GDS)
dfd2149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ghjpk @klayoutmatthias
You can’t perform that action at this time.