Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIF reader issue and writer bug on small rotation angles #568

Closed
klayoutmatthias opened this issue May 24, 2020 · 0 comments
Closed

CIF reader issue and writer bug on small rotation angles #568

klayoutmatthias opened this issue May 24, 2020 · 0 comments
Assignees
@klayoutmatthias
Labels
for-0.26

Comments

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented May 24, 2020 •
edited
Loading

This is related to the post here:

https://www.klayout.de/forum/discussion/1539/cif-visualisation-glitch-and-writing-bug-with-a-cell-rotated-by-5-degrees#latest

The reader bug consists of creating a box with coordinates 0,0..0.999,0.999 instead of 0,0..1,1. It is reproducible on Windows 10, 64bit.

Writer bug: Saving the file will render an invalid transformation. For example here:

C2 R9.00719925474e+15,9.0370723779e+14 T0,0;
@klayoutmatthias klayoutmatthias self-assigned this May 24, 2020
klayoutmatthias added a commit that referenced this issue May 24, 2020
@klayoutmatthias
Fixed bug #568 (CIF writer issue with small rotation angles)
83c6108
@klayoutmatthias klayoutmatthias changed the title CIF writer bug on small rotation angles CIF reader issue and writer bug on small rotation angles May 25, 2020
klayoutmatthias added a commit that referenced this issue May 25, 2020
@klayoutmatthias
Fixed bug #568 (CIF writer issue with small rotation angles) (#569)
a046457 
* Fixed bug #568 (CIF writer issue with small rotation angles)

* Fixed the reader bug too which created the rounding issue.
klayoutmatthias added a commit that referenced this issue May 25, 2020
@klayoutmatthias
Fixed bug #568 (CIF writer issue with small rotation angles) (#569)
e45037a 
* Fixed bug #568 (CIF writer issue with small rotation angles)

* Fixed the reader bug too which created the rounding issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
for-0.26
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@klayoutmatthias