Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRC "Source#select" does not work as documented #651

Closed
klayoutmatthias opened this issue Oct 8, 2020 · 1 comment
Closed

DRC "Source#select" does not work as documented #651

klayoutmatthias opened this issue Oct 8, 2020 · 1 comment
Assignees
Labels

Comments

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Oct 8, 2020

1.) Contrary to the documentation, the "select" feature modifies the source rather than returning a copy.

Technical reason is the "dup" function which does not create a deep copy.

Workaround: Instead of using

only_CELL_and_below = source.select("-TOP", "+CELL")

use

only_CELL_and_below = layout(source.cell_obj).select("-TOP", "+CELL")

2.) There is an undocumented and useful feature to use only "-" for disabling the top cell. But it's not working :(

To disable to the top cell, use

source.select("-" + source.cell_name, "+CELL")

3.) Hierarchical selection "with cells below" may not render the desired results in deep mode. Reason: this requires cell variants as one cell may be selected in one path, but not in the other. Currently, cell variant building is not supported.

@klayoutmatthias klayoutmatthias changed the title Some DRC functions with Source objects don't act on copies as they are supposed to DRC "Source#select" does not work as documented Oct 8, 2020
@klayoutmatthias klayoutmatthias self-assigned this Oct 9, 2020
@klayoutmatthias
Copy link
Collaborator Author

PR #654 fixes the three issues mentioned in the ticket.

klayoutmatthias added a commit that referenced this issue Oct 10, 2020
* WIP: added test case, fixed dup problem and '-' shortcut

* WIP: updated DRC doc and could not resist the temptation to fix 'it's' vs. 'its'

* Deep mode also working with select now. Updated tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant