Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$menu-path location does not work correctly: macOS-specific #658

Closed
Kazzz-S opened this issue Oct 17, 2020 · 5 comments
Closed

$menu-path location does not work correctly: macOS-specific #658

Kazzz-S opened this issue Oct 17, 2020 · 5 comments
Milestone
0.26.9

Comments

@Kazzz-S
Copy link
Contributor

Kazzz-S commented Oct 17, 2020

PYA-OpenRecent.zip

Attached are simple PYA macros that manipulate the recently opened files.
They are functioning as intended. However, I cannot insert the menus to the right locations.
I've tested the macros with KLayout-0.26.8 on different platforms. It is a purely macOS specific issue.

Mac
Linux

Kazzz-S
@Kazzz-S Kazzz-S mentioned this issue Oct 17, 2020
Open
@klayoutmatthias
Copy link
Collaborator

@Kazzz Thanks for reporting this. Any yes, you're right - it seems to be MacOS specific. I'll need to debug this problem there.

Maybe this will also fix the related issues from #657. There seems to be something wrong with the menu path deduction.

Best regards,

Matthias

klayoutmatthias pushed a commit that referenced this issue Oct 27, 2020
Fixed (hopefully) #658 - needs some testing
7e43526 
This patch introduces a slightly more elaborate scheme for building
menus on MacOS. Under normal circumstances, this scheme should maintain
the menu item order as far as possible when Qt is trying to sync with
Mac's menu bar.
@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Oct 27, 2020 •
edited

I have provided PR #665 for the 0.26 branch which hopefully fixes the problem. @Kazzz maybe you can give that one a try - I'd need some test support on MacOS.

The proper ordering of the menu items was actually disabled because Qt segfaulted sometimes when menu items got deleted and re-inserted. The patch provides a somewhat more elaborate implementation of the menu sync function which - under normal circumstances - should maintain the menu item order.

As a side effect, the LVS and DRC menus now are in the same position in the "Tools" menu as they are on Windows and Linux.

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Oct 27, 2020

@klayoutmatthias,

Thank you for delivering PR #665.
I want to test it and get back to you ASAP. However, I'm busy this week.
I hope I can report back around November 3rd.

Kazzz-S

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Nov 2, 2020 •
edited

@klayoutmatthias,

I've tested PR #665, which works fine, as shown below.
Different DMGs for Catalina are available here.

Perhaps OK on the older operating systems, too.
I'm going to check one by one.
Thanks a lot!

Fix658-Catalina-STFix658-Linux

Kazzz-S

OS Test Date Status DMG Date
Catalina 10.15 2020-11-02 OK 2020-10-31
Mojave 10.14 2020-11-02 OK 2020-11-02
High Sierra 10.13 2020-11-03 OK 2020-11-03
Sierra 10.12 2020-11-04 OK 2020-11-04
El Capitan 10.11 2020-11-04 OK 2020-11-04

klayoutmatthias added a commit that referenced this issue Nov 13, 2020
@klayoutmatthias
Fixed (hopefully) #658 - needs some testing (#665)
63291ae 
This patch introduces a slightly more elaborate scheme for building
menus on MacOS. Under normal circumstances, this scheme should maintain
the menu item order as far as possible when Qt is trying to sync with
Mac's menu bar.

Co-authored-by: Matthias <klayoutmatthias>
klayoutmatthias added a commit that referenced this issue Nov 13, 2020
@klayoutmatthias
Port of #658 fix to master
ad0cad8
klayoutmatthias added a commit that referenced this issue Nov 15, 2020
@klayoutmatthias
Merge pull request #678 from KLayout/port-658-to-master
beae26e 
Port of #658 fix to master
@klayoutmatthias klayoutmatthias added this to the 0.26.9 milestone Nov 23, 2020
@klayoutmatthias
Copy link
Collaborator

Fix is released in 0.26.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.26.9
Development

No branches or pull requests
2 participants
@Kazzz-S @klayoutmatthias