Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rational Splines not supported DXF #704

Closed
klayoutmatthias opened this issue Jan 18, 2021 · 0 comments
Closed

Rational Splines not supported DXF #704

klayoutmatthias opened this issue Jan 18, 2021 · 0 comments
Assignees
@klayoutmatthias
Labels
for-0.26
Milestone
0.26.10

Comments

@klayoutmatthias
Copy link
Collaborator

SPLINE entities are supported, but the spline type (record 70) is ignored. Rationale splines are not reproduced properly. Code 8 is supported so far.

I have a test case for rationale splines now (code 12). But none for the other flags.

image
klayoutmatthias added a commit that referenced this issue Jan 18, 2021
@klayoutmatthias
Fixed issue #704. TODO: replace algorithm by De Boor, check if accura…
3524de6 
…cy is still maintained.
@klayoutmatthias klayoutmatthias modified the milestones: 0.27, 0.26.10 Jan 20, 2021
@klayoutmatthias klayoutmatthias self-assigned this Jan 20, 2021
@lukasc-ubc lukasc-ubc mentioned this issue Jan 21, 2021
Merged
klayoutmatthias added a commit that referenced this issue Jan 27, 2021
@klayoutmatthias
Fixed #704 (DXF reader: rational splines not supported) (#705)
233bff5 
* Fixed issue #704. TODO: replace algorithm by De Boor, check if accuracy is still maintained.

* Switch spline interpolation algorithm to De Boor for better numerical stability.

* Updated tests with DXF accuracy test, provide a warning for unsupported SPLINE types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klayoutmatthias klayoutmatthias

Labels
for-0.26
Projects
None yet
Milestone
0.26.10
Development

No branches or pull requests
1 participant
@klayoutmatthias