Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDS export issue #718

Closed
klayoutmatthias opened this issue Jan 31, 2021 · 0 comments
Closed

GDS export issue #718

klayoutmatthias opened this issue Jan 31, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@klayoutmatthias
Copy link
Collaborator

klayoutmatthias commented Jan 31, 2021

gds_export_issue.zip

To reproduce: Save the attached GDS with "max vertices = 15". The issue can be seen on layer 100 (please ignore layer 0).

In the output GDS, the hole on the right side will be filled.

Input:

image

Output (with max vertex count = 15):

image

klayoutmatthias added a commit that referenced this issue Jan 31, 2021
- disabled elaborate hole insertion procedure for now as the
  performance impact has to be assessed yet and the new scheme
  will break many tests
- stricter rejection of ambiguous configurations in the polygon cutter
- fallback is boolean AND now since there is no need to re-invoke the
  polygon cutter (we can't do so as we made it more strict).
  Performance-wise we replace a merge by an AND step which may even be
  faster the output is smaller and the polygon cutter does not need
  to be re-invoked.
@klayoutmatthias klayoutmatthias added this to the 0.26.10 milestone Jan 31, 2021
@klayoutmatthias klayoutmatthias self-assigned this Jan 31, 2021
klayoutmatthias added a commit that referenced this issue Jan 31, 2021
* WIP: first part of fix - generation of hole cutlines

First problem was that hole cutlines got extended
over the whole length and sometimes lead to coincident
edges which are difficult to resolve for the polygon
cutter.

* Refined solution, fixed #718

- disabled elaborate hole insertion procedure for now as the
  performance impact has to be assessed yet and the new scheme
  will break many tests
- stricter rejection of ambiguous configurations in the polygon cutter
- fallback is boolean AND now since there is no need to re-invoke the
  polygon cutter (we can't do so as we made it more strict).
  Performance-wise we replace a merge by an AND step which may even be
  faster the output is smaller and the polygon cutter does not need
  to be re-invoked.

* Compatibility with other STLs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant