Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build on Debian hppa: uses non-standard sa_restorer field of struct sigaction #728

Closed
jscott0 opened this issue Feb 8, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@jscott0
Copy link

jscott0 commented Feb 8, 2021

Hi,

I'm forwarding this issue on behalf of a reporter in Debian. Since merging #656 it seems like there's a hard-coded assumption that systems other than macOS and the BSDs have the sa_restorer field, but we use the GNU C Library and it doesn't provide this for hppa at least.

KLayout should test at build time whether the field exists, or set only the fields specified by POSIX and allow the rest to be zeroed out (perhaps with designated initializers). Note that my Linux man page says

The sa_restorer field is not intended for application use.

@klayoutmatthias
Copy link
Collaborator

Thanks for reporting this issue.

I'll use a fetch-and-modify scheme to install the signal handlers to get rid of the #ifdefs and the OS dependencies.

Matthias

@klayoutmatthias klayoutmatthias added this to the 0.26.11 milestone Feb 14, 2021
@klayoutmatthias klayoutmatthias self-assigned this Feb 14, 2021
klayoutmatthias added a commit that referenced this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants