Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEF/DEF flow - duplicate text label generated #824

Closed
refob opened this issue Jun 4, 2021 · 3 comments
Closed

LEF/DEF flow - duplicate text label generated #824

refob opened this issue Jun 4, 2021 · 3 comments
Assignees
Labels
Milestone

Comments

@refob
Copy link

refob commented Jun 4, 2021

Please install the package load_lefdef_tutorial from the Salt.Mine. Then cd to ~/.klayout/salt/load_lefdef_tutorial. Then run "make lefdef".

In klayout show cell BUFX2 as new top cell. Watch the blue text labels A+Y+vdd+gnd.

Now hide the layer "metal1.pin -81/0". You can see that these labels also exist on layer "text.drawing - 109/0".

This is not correct. The mapfile input/klayout/cmos180.encmap should put

LEF pins only on layer 109/0
metal1 LEFPIN 81 0

DEF pins only on layers 81, 82 etc.
NAME metal1/PIN 81 0
NAME metal2/PIN 82 0

You can also check the toplevel cell - you also find duplicate labels there. There should be nothing on 109/0 according ot the map file.

klayoutmatthias added a commit that referenced this issue Jun 8, 2021
@klayoutmatthias
Copy link
Collaborator

@refob Thanks for that testcase and the impressive tutorial!

I was not aware that labels are differentiated by purpose. Right now, there is only one "label" purpose and both LEF and DEF pin purposes are combined.

My proposed fix is to supply a new mapping purpose "LEF pin label" which I map "NAME M1/LEFPIN ..." to:

image

Matthias

@klayoutmatthias klayoutmatthias self-assigned this Jun 8, 2021
@klayoutmatthias klayoutmatthias added this to the 0.27.2 milestone Jun 8, 2021
@refob
Copy link
Author

refob commented Jun 9, 2021

The proposed mapping is fine. I suggest change the labels from "Pins ()" to "DEF PIns ()" and from "Pin Labels" to "DEF Pin Labels" to clarify the sources more accurately.

@klayoutmatthias
Copy link
Collaborator

Thanks for this hint. I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants