Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: toggle on/off editor options window #918

Closed
g2hollow opened this issue Oct 13, 2021 · 11 comments
Closed

Feature Request: toggle on/off editor options window #918

g2hollow opened this issue Oct 13, 2021 · 11 comments
Assignees
Labels
Milestone

Comments

@g2hollow
Copy link

Hello,

Upon updating to 0.27.x I find that every time I click the menu button to create a new shape (polygon, box, etc), the 'editor options' window pops up. I can dock this window which helps a bit, but I would like the option to not have it present when creating new shapes. Most of the time once I've set up the editor options I don't need to change them very frequently, and this floating or docked window is taking up a lot of GUI real-estate especially on smaller laptop screens. Prior to 0.27.x this didn't seem to be the behavior I experienced, if it would be possible to add some menu option to prevent 'editor options' from popping up or needing to be docked it would be appreciated.

Best,
-Greg

@klayoutmatthias
Copy link
Collaborator

You can actually reduce the size (it's docked by default BTW), so it does not take a lot of real estate:

image

It offers some added value like the recent styles and needs to be there for 3 out of 5 objects (paths, texts and instances).

So simply disabling it does not make sense. I think it's a useful feature and I like it the way it is.

@g2hollow
Copy link
Author

Thank you for your consideration, and explanation. I understand your reasoning. Also thank you for creating this software and continuing to maintain it, it is fantastic.

@klayoutmatthias
Copy link
Collaborator

Thanks! :)

I actually did not want to imply you should close this issue. I thought of my comment some kind of voting - if I sense that the idea of the request is shared by others I will usually try to find a compromise.

On the other hand - every closed ticket is one less on the heap :)

Best regards,

Matthias

@g2hollow
Copy link
Author

Perhaps I closed this pre-emptively. I was just playing around with a few versions and I see why I was initially concerned with the loss of realestate. Therefore I'll reopen and explain.

In version 0.27.4 the docked window can only be shrunk so far. In this case the docked window takes up approximately 1/3 of my window with my resolution settings. It is quite a dramatic change in view from previous versions.

docked_0 27 4

For comparison in 0.27.3 the docked window can be shrunk significantly so that this left menu bar is a similar width to previous versions. In this case the loss of realestate is negligible.

docked_0 27 3

Would it be possible to be able to resize the window in 0.27.4 like it was in 0.27.3. In this case I would be completely satisfied. My apologies for flip-flopping around on this.

@g2hollow g2hollow reopened this Oct 13, 2021
@lukasc-ubc
Copy link

lukasc-ubc commented Oct 14, 2021 via email

@klayoutmatthias
Copy link
Collaborator

I don't know why 0.27.4 behaves differently. I'll take a look.

But you can also arrange the dockable windows in tabs, like this:

image

this is no loss of real estate then.

Matthias

@klayoutmatthias
Copy link
Collaborator

Looks like this is a windows specific problem. On Linux 0.27.4 is lean as ever.

@klayoutmatthias
Copy link
Collaborator

More specifically, it's a problem of Qt 5.15

@klayoutmatthias klayoutmatthias self-assigned this Oct 14, 2021
@klayoutmatthias klayoutmatthias added this to the 0.27.5 milestone Oct 14, 2021
@Kazzz-S
Copy link
Contributor

Kazzz-S commented Oct 14, 2021

Here are some quick test results on Mac.
The patch is not yet applied.
It looks that the issue is Qt 5.15.x-specific.
Kazzz-S

Standard-5 15 2

MacPorts-5 12 2

Homebrew-5 15 2

Anaconda-5 9 7

@Kazzz-S
Copy link
Contributor

Kazzz-S commented Oct 15, 2021

Hi, @klayoutmatthias,

I have tested with c48f930
Thank you for fixing this problem.
Kazzz-S

patchVersion

patchST-5 12 2

patchMacPorts-5 12 2

patchHomebrew-5 12 2

patchAnaconda3-5 9 7

@klayoutmatthias
Copy link
Collaborator

Wow! :)

I was able to find a fix for this problem - apparently Qt 5.15 chooses a different default size policy for this case. 0.27.5 will contain the patch.

Matthias

klayoutmatthias added a commit that referenced this issue Oct 15, 2021
Fixed #918 by using ignore size policy for the editor options tab widget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants