New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sailsjs configuration format to support v1. #36

Merged
merged 3 commits into from Oct 2, 2017

Conversation

Projects
None yet
2 participants
@mrded
Contributor

mrded commented Sep 29, 2017

sails.config.connections -> sails.config.datastores
sails.config.models.connection -> sails.config.models.datastore

Update sailsjs configuaration format to v1.
sails.config.connections -> sails.config.datastores
sails.config.models.connection -> sails.config.models.datastore

@mrded mrded referenced this pull request Sep 29, 2017

Closed

Sails.js v1 support #35

@KSDaemon

What do you think about my ideas?

Also please add working tests for your changes. It will be great, if we can create a tests both for v0.12 and v1.0 version.

Show outdated Hide outdated index.js
Show outdated Hide outdated index.js
Show outdated Hide outdated index.js
@mrded

This comment has been minimized.

Show comment
Hide comment
@mrded

mrded Sep 29, 2017

Contributor

I tried to run tests on v.1.1.0 version without my changes, and all tests fail the same way. Are you sure that tests are working?

Contributor

mrded commented Sep 29, 2017

I tried to run tests on v.1.1.0 version without my changes, and all tests fail the same way. Are you sure that tests are working?

@KSDaemon

This comment has been minimized.

Show comment
Hide comment
@KSDaemon

KSDaemon Sep 29, 2017

Owner

Hmm... Yes, tests are working as on mine two computers, also on travis-ci. You can check Details link

Owner

KSDaemon commented Sep 29, 2017

Hmm... Yes, tests are working as on mine two computers, also on travis-ci. You can check Details link

Show outdated Hide outdated index.js
@mrded

This comment has been minimized.

Show comment
Hide comment
@mrded

mrded Sep 30, 2017

Contributor

Also please add working tests for your changes. It will be great, if we can create a tests both for v0.12 and v1.0 version.

I'm not really sure how to make tests for different version of packages. Can you help me with that?

Contributor

mrded commented Sep 30, 2017

Also please add working tests for your changes. It will be great, if we can create a tests both for v0.12 and v1.0 version.

I'm not really sure how to make tests for different version of packages. Can you help me with that?

@KSDaemon

This comment has been minimized.

Show comment
Hide comment
@KSDaemon

KSDaemon Oct 2, 2017

Owner

Ok, i'll merge this PR, as current tests are passed :)
And i'll try to create backbone for mutiversion tests!

Owner

KSDaemon commented Oct 2, 2017

Ok, i'll merge this PR, as current tests are passed :)
And i'll try to create backbone for mutiversion tests!

@KSDaemon KSDaemon merged commit 7e264d7 into KSDaemon:master Oct 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mrded

This comment has been minimized.

Show comment
Hide comment
@mrded

mrded Oct 2, 2017

Contributor

Great, thank you!

Contributor

mrded commented Oct 2, 2017

Great, thank you!

@mrded mrded deleted the mrded:sailsjs-v1 branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment