Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test upgrading mod with conflict on its own provides #2431

Merged
merged 1 commit into from Apr 28, 2018

Conversation

@HebaruSan
Copy link
Member

commented Apr 27, 2018

#2430 added a test of the sanity checker to make sure that multiple versions of a mod that conflicts with its own identifier don't conflict with one another. This is a requirement for the way upgrades work.

However, users also reported the same problem for a slightly different scenario. A mod can also self-conflict if it both "provides" an identifier and "conflicts" with that same identifier. VesselMoverContinued and MechJeb2-RO suffer from this variant of the problem (they provide and conflict with VesselMover and MechJeb2, respectively). The actual fix covers both scenarios, but the test only checks conflicts with the identifier, so it's not inconceivable that some future change might break them separately and not be caught.

This pull request adds a test to catch this case.

@politas politas merged commit b381906 into KSP-CKAN:master Apr 28, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
politas added a commit that referenced this pull request Apr 28, 2018
@politas politas removed the Pull request label Apr 28, 2018
@HebaruSan HebaruSan deleted the HebaruSan:fix/provides-self-conflict-test branch Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.