Add libcurl dependency to RPM

[HebaruSan]

Our wiki instructions for installing on Fedora say to install libcurl-devel manually:

https://github.com/KSP-CKAN/CKAN/wiki/Installing-CKAN-on-Fedora#libcurl

If this is needed, the RPM should handle it as a dependency. Now it will.

[DasSkelett]

Did you test it on openSUSE?
Their online package list doesn't look like it has a package called only libcurl-devel, but maybe they don't list metapackages/aliases there?
https://software.opensuse.org/search?utf8=%E2%9C%93&baseproject=ALL&q=libcurl

[HebaruSan]

Did you test it on openSUSE?

Looks OK:

> sudo zypper install ckan-1.26.5-1.noarch.rpm 
[sudo] password for root: 
Loading repository data...
Reading installed packages...
Resolving package dependencies...

The following 3 NEW packages are going to be installed:
  glibc-devel libcurl-devel linux-glibc-devel

The following package is going to be upgraded:
  ckan

1 package to upgrade, 3 new.
Overall download size: 1001.9 KiB. Already cached: 2.7 MiB. After the operation,
additional 5.7 MiB will be used.
Continue? [y/n/v/...? shows all options] (y): 
In cache linux-glibc-devel-4.15-lp151.2.72.noarch.rpm
                                                   (1/4),   1.3 MiB (  5.7 MiB unpacked)
In cache glibc-devel-2.26-lp151.18.7.x86_64.rpm    (2/4), 751.2 KiB (  2.9 MiB unpacked)
In cache libcurl-devel-7.60.0-lp151.5.3.1.x86_64.rpm
                                                   (3/4), 722.5 KiB (793.6 KiB unpacked)
Retrieving package ckan-1.26.5-1.noarch           (4/4), 1001.9 KiB (  3.5 MiB unpacked)
ckan-1.26.5-1.noarch.rpm:
    Package is not signed!

ckan-1.26.5-1.noarch (Plain RPM files cache): Signature verification failed [6-File is unsigned]
Abort, retry, ignore? [a/r/i] (a): i
Checking for file conflicts: .........................[done]
(1/4) Installing: linux-glibc-devel-4.15-lp151.2.72.noarch ...................[done]
(2/4) Installing: glibc-devel-2.26-lp151.18.7.x86_64 ...........................[done]
(3/4) Installing: libcurl-devel-7.60.0-lp151.5.3.1.x86_64 .........................[done]
(4/4) Installing: ckan-1.26.5-1.noarch ............................[done]
Additional rpm output:
Unknown option or file not found '/etc/pki/tls/certs/ca-bundle.crt'.
Mono Certificate Store Sync - version 5.10.1.47
Populate Mono certificate store from a concatenated list of certificates.
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Usage: cert-sync [--quiet] [--user] system-ca-bundle.crt
Where system-ca-bundle.crt is in PEM format
Unknown option or file not found '/etc/pki/tls/cert.pem'.
Mono Certificate Store Sync - version 5.10.1.47
Populate Mono certificate store from a concatenated list of certificates.
Copyright 2002, 2003 Motus Technologies. Copyright 2004-2008 Novell. BSD licensed.

Usage: cert-sync [--quiet] [--user] system-ca-bundle.crt
Where system-ca-bundle.crt is in PEM format
warning: %post(ckan-1.26.5-1.noarch) scriptlet failed, exit status 1


There are some running programs that might use files deleted by recent upgrade. You may wish to check and restart some of them. Run 'zypper ps -s' to list these programs.
 
Core libraries or services have been updated.
Reboot is required to ensure that your system benefits from these updates.

[DasSkelett]

Then I don't understand their online package list...
But if it works 🤷‍♂️