Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only redeploy the metadata tester on repo dispatch #4094

Merged
merged 1 commit into from
May 21, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented May 21, 2024

Background

#3575, KSP-CKAN/NetKAN-Infra#267, and KSP-CKAN/xKAN-meta_testing#86 made it so the main CKAN repo would run its deploy.yml workflow anytime we pushed changes to the Python code from the other two repos.

Motivation

Currently the entire deploy.yml worklow is run, including some unnecessary jobs:

  • Uploading ckan.exe and netkan.exe to S3
  • Building the rpm/deb packages and uploading them to S3
  • Rebuilding, pushing, and redeploying the Inflator

This takes a little more time and may unnecessarily mark some files as changed when they really aren't.

Changes

Now when deploy.yml is triggered from NetKAN-Infra or xKAN-meta_testing, we only rebuild and push the metadata tester image (and run its dependencies). This is the only job that depends on the Python code from those other repos.

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix Build Issues affecting the build system Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Performance Something's slower than it should be labels May 21, 2024
@HebaruSan HebaruSan merged commit 6754dd9 into master May 21, 2024
6 checks passed
@HebaruSan HebaruSan deleted the refactor/dispatch branch May 21, 2024 20:47
HebaruSan added a commit to HebaruSan/NetKAN-Infra that referenced this pull request May 21, 2024
HebaruSan added a commit to KSP-CKAN/NetKAN-Infra that referenced this pull request May 21, 2024
@HebaruSan
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Issues affecting the build system Easy This is easy to fix Enhancement Infrastructure Issues affecting everything around CKAN (the GitHub repos, build process, CI, ...) Performance Something's slower than it should be
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant