New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zenit3SLBReduzx #5176

Merged
merged 5 commits into from Jan 18, 2017

Conversation

Projects
None yet
2 participants
@linuxgurugamer
Contributor

linuxgurugamer commented Jan 17, 2017

No description provided.

@linuxgurugamer

This comment has been minimized.

Contributor

linuxgurugamer commented Jan 17, 2017

8193 [1] FATAL CKAN.NetKAN.Program (null) - Too may .version files located: HorizonAeronautics_V1.32/GameData/AnimatedDecouplers/AnimatedDecouplers.version, __MACOSX/HorizonAeronautics_V1.32/GameData/AnimatedDecouplers/._AnimatedDecouplers.version Build step 'Execute shell' marked build as failure

It gets stuck on a .version file in the AnimatedDecouplers folder. I'm not sure why it's looking there tbh since the CKAN-spec clearly states that Only .version files that would be installed for this mod are considered. and the find directive should only work against the top-most matching directory which shouldn't be in the _MACOSX folder since that makes everything one layer deeper. Not sure how to ping on this but I'm guessing @dbent since it seems NetKAN isn't doing what the spec says it should be doing.

@politas

This comment has been minimized.

Member

politas commented Jan 17, 2017

I think that Netkan is downloading and looking for .version files before it gets to the filtering part of the instructions. You can specify the name of the .version file to force the correct file. eg.

"$vref": "#/ckan/ksp-avc/horizonaeronautics.version/",
@linuxgurugamer

This comment has been minimized.

Contributor

linuxgurugamer commented Jan 17, 2017

Thanks, I'll fix that, but isn't this non-spec?

linuxgurugamer added some commits Jan 17, 2017

@linuxgurugamer

This comment has been minimized.

Contributor

linuxgurugamer commented Jan 17, 2017

This file doesn't have a .version, so I just removed the $cref line

@politas

This comment has been minimized.

Member

politas commented Jan 17, 2017

The spec was missing some details there. I've updated it.
Ah, not duplicate .versions, but no .version at all!

@politas politas merged commit 5659f72 into KSP-CKAN:master Jan 18, 2017

1 check passed

default Build finished.
Details
@politas

This comment has been minimized.

Member

politas commented Jan 18, 2017

Sorry, meant to merge this earlier, but fatigue drove me off to bed.

@politas politas removed the Ready to Merge label Jan 18, 2017

blowfishpro added a commit to blowfishpro/NetKAN that referenced this pull request Apr 25, 2017

Zenit3SLBReduzx (KSP-CKAN#5176)
* Zenit3SLBReduzx

* Update Zenit3SLBReduzx.netkan

* Update Zenit3SLBReduzx.netkan

* Update Zenit3SLBReduzx.netkan

* Update Zenit3SLBReduzx.netkan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment