Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2377 - Added cid suffix to PartValue #2378

Merged
merged 1 commit into from Feb 1, 2019
Merged

Fixes #2377 - Added cid suffix to PartValue #2378

merged 1 commit into from Feb 1, 2019

Conversation

lucaelin
Copy link
Contributor

@lucaelin lucaelin commented Dec 13, 2018

Fixes #2377
This PR is NOT READY yet as i have not tested the cid behavior in case of docking and such...
It's also missing documentation as it is super hard for me to correctly formulate things like this 馃檲

@Dunbaratu
Copy link
Member

Dunbaratu commented Dec 14, 2018

So if I understand the difference between UID and CID, is it this?

If you take the same craft file, and launch it twice under different vessel names "instance1", and "instance2", then this would happen:

This results in False:

  • set test to (vessel("instance1"):parts[5]:UID = vessel("instance2"):parts[5]:UID).

But this results in True:

  • set test to (vessel("instance1"):parts[5]:CID = vessel("instance2"):parts[5]:CID).

@lucaelin
Copy link
Contributor Author

Exactly.

@Dunbaratu
Copy link
Member

Dunbaratu commented Feb 1, 2019

@lucaelin - You said this Pull Request was "NOT READY" when you first made it. That was quite a while ago. Do you still see it as "not tested" or do you want me to merge it for the release coming up?

@lucaelin
Copy link
Contributor Author

lucaelin commented Feb 1, 2019

I still havn't tested any docking scenarios... I'm gonna do that today. But in addition to testing the exact behavior, the PR still needs documentation.

@lucaelin
Copy link
Contributor Author

lucaelin commented Feb 1, 2019

I just tested docking and it works just like i expected it to. Once two crafts created using the same craft file dock to eachother, there are two parts on the (joined) craft with the same cid. Once undocked, each ship has its own part back :) The cid doesn't change in this process.

@Dunbaratu Dunbaratu merged commit 0a8c3ac into KSP-KOS:develop Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants