Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logspam is back #27

Closed
NathanKell opened this issue Jul 14, 2016 · 6 comments

Comments

@NathanKell
Copy link
Member

commented Jul 14, 2016

Looks like the fix that removed the log lines in TACLS's resource request method got reverted again, because I"m back to getting logspam in 0.12.2. This makes KSP write to log every frame when RO is installed, drastically slowing things down.
Look for STAGE_PRIORITY_FLOW in the codebase. Please just comment that line (and the other debug lines there).

@danfarnsy

This comment has been minimized.

Copy link

commented Jul 14, 2016

I'll try to get to it today.

@danfarnsy danfarnsy self-assigned this Jul 14, 2016

@NathanKell

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2016

Thanks much! :)

@JPLRepo

This comment has been minimized.

Copy link

commented Aug 14, 2016

@danfarnsy have you made this change?

@JPLRepo JPLRepo assigned JPLRepo and unassigned danfarnsy Aug 15, 2016

@danfarnsy

This comment has been minimized.

Copy link

commented Aug 16, 2016

@JPLRepo , negative, this still needs to be made.

@JPLRepo JPLRepo added this to the V0.12.3 milestone Aug 16, 2016

JPLRepo pushed a commit that referenced this issue Aug 16, 2016
@JPLRepo

This comment has been minimized.

Copy link

commented Aug 16, 2016

@JPLRepo

This comment has been minimized.

Copy link

commented Aug 17, 2016

Tested successfully. Ready to Implement.

@JPLRepo JPLRepo closed this Aug 24, 2016

keyspace added a commit to keyspace/TacLifeSupport that referenced this issue Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.