Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix address binding for "examples/sm_manager" #87

Merged
merged 2 commits into from Dec 24, 2019

Conversation

@HAOYUatHZ
Copy link
Contributor

HAOYUatHZ commented Dec 16, 2019

"examples/sm_manager" is implemented using https://rocket.rs/

Current config Rocket.toml is incompatible with #88

This PR fixes the address config to support running sm_manager in docker.

@omershlo omershlo requested a review from gbenattar Dec 19, 2019
@HAOYUatHZ

This comment has been minimized.

Copy link
Contributor Author

HAOYUatHZ commented Dec 21, 2019

Hi @gbenattar
you can just simply run ./demo/run.sh to test this PR
(This PR is to change sm_manager binding address in Rocket server config)
it works good on my machine

@HAOYUatHZ HAOYUatHZ changed the title fix address binding for rocket server fix address binding for "examples/sm_manager" Dec 23, 2019
@gbenattar

This comment has been minimized.

Copy link
Member

gbenattar commented Dec 24, 2019

LGTM as long as it is good for @omershlo. You can go ahead and squash and merge.

@omershlo omershlo merged commit b68db7a into KZen-networks:master Dec 24, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.