Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Unicode \ll and \lll #1273

Merged
merged 2 commits into from Apr 25, 2018

Conversation

@ronkok
Copy link
Collaborator

commented Apr 24, 2018

Fixes #1272. Consistent with unicode-math

Support Unicode \ll and \lll
Fixes #1272. Consistent with `unicode-math`
@codecov

This comment has been minimized.

Copy link

commented Apr 24, 2018

Codecov Report

Merging #1273 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1273   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          60       60           
  Lines        3880     3880           
  Branches      651      651           
=======================================
  Hits         3199     3199           
  Misses        578      578           
  Partials      103      103
Impacted Files Coverage Δ
src/symbols.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812b350...c3e29c2. Read the comment docs.

@kevinbarabash
Copy link
Member

left a comment

Thanks for the quick response to this issue.

@@ -2976,7 +2976,7 @@ describe("Unicode", function() {
});

it("should parse relations", function() {
expect("∈∋∝∼∽≂≃≅≈≊≍≎≏≐≑≒≓≖≗≜≡≤≥≦≧≫≬≳≷≺≻≼≽≾≿∴∵∣≔≕⩴").toParse();
expect("∈∋∝∼∽≂≃≅≈≊≍≎≏≐≑≒≓≖≗≜≡≤≥≦≧≫≬≳≷≺≻≼≽≾≿∴∵∣≔≕⩴≪⋘").toParse();

This comment has been minimized.

Copy link
@kevinbarabash

kevinbarabash Apr 25, 2018

Member

Can you put beside the ? There should also be \ggg can you add the unicode char for that beside the ?

This comment has been minimized.

Copy link
@ronkok

ronkok Apr 25, 2018

Author Collaborator

Done.

@kevinbarabash
Copy link
Member

left a comment

LGTM. Thanks for the PR.

@kevinbarabash kevinbarabash merged commit b4b57cb into KaTeX:master Apr 25, 2018

4 checks passed

ci/circleci: chrome Your tests passed on CircleCI!
Details
ci/circleci: firefox Your tests passed on CircleCI!
Details
codecov/project 82.44% (+0%) compared to 812b350
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ronkok ronkok deleted the ronkok:lll branch Apr 25, 2018

@edemaine

This comment has been minimized.

Copy link
Member

commented Apr 25, 2018

That was fast! Thanks @ronkok and @kevinbarabash!

@ylemkimon ylemkimon referenced this pull request Aug 18, 2018
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.