Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix \coloneq etc #1372

Merged
merged 2 commits into from May 28, 2018

Conversation

@ronkok
Copy link
Collaborator

commented May 27, 2018

Fixes issue #1333.

\coloneq and several similar functions are written as macros. When expanded, these macros result in atoms like ":" and "=" placed adjacent to each other at the top level. So they are exposed to being split by an automatic line break.

This PR wraps each of these macros in an \mathrel{ }. The braces prevent the line break. The \mathrel preserves the correct spacing.

Fix coloneq etc
Fix issue #1333.

`\coloneq` and several similar functions are written as macros. When expanded, these result in atoms like ":" and "=" placed adjacent to each other at the top level. So they exposed to a split by an automatic line break.

This PR wraps each of these macros in an `\mathrel{ }`. This prevents the line break.

@ronkok ronkok requested a review from edemaine May 27, 2018

@codecov

This comment has been minimized.

Copy link

commented May 27, 2018

Codecov Report

Merging #1372 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1372   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files          77       77           
  Lines        4227     4227           
  Branches      731      731           
=======================================
  Hits         3434     3434           
  Misses        673      673           
  Partials      120      120
Impacted Files Coverage Δ
src/macros.js 86.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41b0b0...003ae35. Read the comment docs.

@ylemkimon ylemkimon merged commit 2974639 into KaTeX:master May 28, 2018

4 checks passed

ci/circleci: chrome Your tests passed on CircleCI!
Details
ci/circleci: firefox Your tests passed on CircleCI!
Details
codecov/project 81.23% (+0%) compared to d41b0b0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ronkok ronkok deleted the ronkok:coloneq branch May 28, 2018

@ylemkimon ylemkimon referenced this pull request Aug 18, 2018
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.