Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #1571

Merged
merged 2 commits into from Aug 19, 2018

Conversation

@ylemkimon
Copy link
Member

commented Aug 8, 2018

Blocked on #1544

@ylemkimon ylemkimon added the blocked label Aug 8, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 8, 2018

Codecov Report

Merging #1571 into master will decrease coverage by 0.47%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1571      +/-   ##
==========================================
- Coverage   84.97%   84.49%   -0.48%     
==========================================
  Files          78       79       +1     
  Lines        4592     4619      +27     
  Branches      806      807       +1     
==========================================
+ Hits         3902     3903       +1     
- Misses        594      619      +25     
- Partials       96       97       +1
Impacted Files Coverage Δ
src/Lexer.js 100% <0%> (ø) ⬆️
src/functions/delimsizing.js 65.51% <0%> (ø) ⬆️
contrib/auto-render/auto-render.js 0% <0%> (ø) ⬆️
src/defineFunction.js 93.75% <0%> (ø) ⬆️
src/SourceLocation.js 100% <0%> (ø) ⬆️
src/unicodeMake.js 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e790a41...520dda3. Read the comment docs.

@edemaine
Copy link
Member

left a comment

Nice changes. I'm going to approve this now, but it shouldn't get merged until it's no longer blocked.

@ylemkimon ylemkimon removed the blocked label Aug 19, 2018

@ylemkimon ylemkimon merged commit 8135611 into KaTeX:master Aug 19, 2018

5 of 6 checks passed

deploy/netlify Deploy preview processing.
Details
Screenshotter - Chrome Screenshotter Passed
Details
Screenshotter - Firefox Screenshotter Passed
Details
ci/circleci: chrome Your tests passed on CircleCI!
Details
ci/circleci: firefox Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details

@ylemkimon ylemkimon deleted the ylemkimon:contributing branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.