Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\fbox inherits default color #1847

Merged
merged 1 commit into from Feb 9, 2019
Merged

Conversation

edemaine
Copy link
Member

@edemaine edemaine commented Feb 9, 2019

Merge .fbox and .fcolorbox rules to inherit default color, instead of forcing black.

We no longer have any explicit black in CSS!

Fix #1772.

Here's a screenshot where I manually modified the default color:

image

Merge `.fbox` and `.fcolorbox` rules to inherit default color, instead
of forcing `black`.  We no longer have any explicit `black` in CSS.
Fix KaTeX#1772.
@codecov-io
Copy link

Codecov Report

Merging #1847 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1847   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files          80       80           
  Lines        4664     4664           
  Branches      811      811           
=======================================
  Hits         4414     4414           
  Misses        225      225           
  Partials       25       25
Flag Coverage Δ
#screenshotter 88.86% <ø> (ø) ⬆️
#test 86.7% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f778d1...097ef84. Read the comment docs.

Copy link
Member

@kevinbarabash kevinbarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants